From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH -V3 5/8] hw/9pfs: Add open flag to fid
Date: Mon, 14 Mar 2011 00:31:24 +0530 [thread overview]
Message-ID: <874o76rgjf.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <AANLkTik_xDvhWvEibPYrv0goY9PZOjkgEDdqctW-_9TU@mail.gmail.com>
On Sun, 13 Mar 2011 16:38:39 +0000, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V
> <aneesh.kumar@linux.vnet.ibm.com> wrote:
> > +static int get_dotl_openflags(int oflags)
> > +{
> > + int flags;
> > + /*
> > + * Since we can share the fd between multiple fids,
> > + * open the file in read write mode
> > + */
>
> I didn't know that fds are shared between fids. Also this code does
> not always open O_RDWR. This comment is incorrect (perhaps a later
> patch changes assumptions, I haven't looked yet, but introducing
> temporary inconsistencies makes it difficult to review and potentially
> confusing for git-bisect users).
>
What i wanted to say there was, we can possibly look at sharing fd
between multiple fids. Will update the comment.
-aneesh
next prev parent reply other threads:[~2011-03-13 19:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 17:52 [Qemu-devel] [PATCH -V3 1/8] hw/9pfs: Add V9fsfidmap in preparation for adding fd reclaim Aneesh Kumar K.V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 2/8] hw/9pfs: Add file descriptor reclaim support Aneesh Kumar K.V
2011-03-13 16:08 ` Stefan Hajnoczi
2011-03-13 18:57 ` Aneesh Kumar K. V
2011-03-14 10:13 ` Stefan Hajnoczi
2011-03-15 8:35 ` Aneesh Kumar K. V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 3/8] hw/9pfs: Use v9fs_do_close instead of close Aneesh Kumar K.V
2011-03-13 16:10 ` Stefan Hajnoczi
2011-03-13 18:58 ` Aneesh Kumar K. V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 4/8] hw/9pfs: Implement syncfs Aneesh Kumar K.V
2011-03-13 16:24 ` Stefan Hajnoczi
2011-03-13 18:59 ` Aneesh Kumar K. V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 5/8] hw/9pfs: Add open flag to fid Aneesh Kumar K.V
2011-03-13 16:38 ` Stefan Hajnoczi
2011-03-13 19:01 ` Aneesh Kumar K. V [this message]
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 6/8] hw/9pfs: Add directory reclaim support Aneesh Kumar K.V
2011-03-13 16:42 ` Stefan Hajnoczi
2011-03-13 19:02 ` Aneesh Kumar K. V
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 7/8] hw/9pfs: Add new virtfs option cache=none to skip host page cache Aneesh Kumar K.V
2011-03-13 17:23 ` Stefan Hajnoczi
2011-03-13 19:04 ` Aneesh Kumar K. V
2011-03-13 20:57 ` Stefan Hajnoczi
2011-03-15 8:36 ` Aneesh Kumar K. V
2011-03-14 10:20 ` Stefan Hajnoczi
2011-03-15 9:19 ` Aneesh Kumar K. V
2011-03-15 11:11 ` Stefan Hajnoczi
2011-03-15 12:30 ` Aneesh Kumar K. V
2011-03-16 8:59 ` Stefan Hajnoczi
2011-03-05 17:52 ` [Qemu-devel] [PATCH -V3 8/8] hw/9pfs: Skip file system sync if we have specified cache=none option Aneesh Kumar K.V
2011-03-13 15:46 ` [Qemu-devel] [PATCH -V3 1/8] hw/9pfs: Add V9fsfidmap in preparation for adding fd reclaim Stefan Hajnoczi
2011-03-13 19:06 ` Aneesh Kumar K. V
2011-03-13 20:53 ` Stefan Hajnoczi
2011-03-14 10:23 ` Stefan Hajnoczi
2011-03-15 9:20 ` Aneesh Kumar K. V
2011-03-15 10:38 ` Stefan Hajnoczi
2011-03-15 12:27 ` Aneesh Kumar K. V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874o76rgjf.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).