From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44061 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PyqXk-000616-Ba
	for qemu-devel@nongnu.org; Sun, 13 Mar 2011 15:01:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1PyqXj-00014x-C0
	for qemu-devel@nongnu.org; Sun, 13 Mar 2011 15:01:32 -0400
Received: from e23smtp09.au.ibm.com ([202.81.31.142]:55903)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1PyqXi-00014o-RE
	for qemu-devel@nongnu.org; Sun, 13 Mar 2011 15:01:31 -0400
Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [202.81.31.246])
	by e23smtp09.au.ibm.com (8.14.4/8.13.1) with ESMTP id p2DJ1TMC016902
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 06:01:29 +1100
Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p2DJ1TpE2535602
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 06:01:29 +1100
Received: from d23av01.au.ibm.com (loopback [127.0.0.1])
	by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p2DJ1TPh001649
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 06:01:29 +1100
From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH -V3 5/8] hw/9pfs: Add open flag to fid
In-Reply-To: <AANLkTik_xDvhWvEibPYrv0goY9PZOjkgEDdqctW-_9TU@mail.gmail.com>
References: <1299347533-17047-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
	<1299347533-17047-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
	<AANLkTik_xDvhWvEibPYrv0goY9PZOjkgEDdqctW-_9TU@mail.gmail.com>
Date: Mon, 14 Mar 2011 00:31:24 +0530
Message-ID: <874o76rgjf.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

On Sun, 13 Mar 2011 16:38:39 +0000, Stefan Hajnoczi <stefanha@gmail.com> wr=
ote:
> On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V
> <aneesh.kumar@linux.vnet.ibm.com> wrote:
> > +static int get_dotl_openflags(int oflags)
> > +{
> > + =C2=A0 =C2=A0int flags;
> > + =C2=A0 =C2=A0/*
> > + =C2=A0 =C2=A0 * Since we can share the fd between multiple fids,
> > + =C2=A0 =C2=A0 * open the file in read write mode
> > + =C2=A0 =C2=A0 */
>=20
> I didn't know that fds are shared between fids.  Also this code does
> not always open O_RDWR.  This comment is incorrect (perhaps a later
> patch changes assumptions, I haven't looked yet, but introducing
> temporary inconsistencies makes it difficult to review and potentially
> confusing for git-bisect users).
>=20

What i wanted to say there was, we can possibly look at sharing fd
between multiple fids. Will update the comment.

-aneesh