From: "Bjørn Mork" <bmork@dod.no>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: multicast and the eepro100 driver
Date: Tue, 18 Dec 2007 15:44:41 +0100 [thread overview]
Message-ID: <874peg83l2.fsf@obelix.mork.no> (raw)
In-Reply-To: 46950F50.5050502@mail.berlios.de
Stefan Weil <weil@mail.berlios.de> writes:
> eepro100.c is my work, so maybe I can help you.
>
> First of all: there exists a newer version of eepro100.c which
> fixes some bugs of the CVS version and largely improves
> support for big endian hosts and targets. Get it from
> http://svn.berlios.de/wsvn/ar7-firmware/qemu/trunk/hw/eepro100.c?op=file&rev=0&sc=0
>
> I am still working on this new version, because support for big endian
> hosts is still untested.
>
> If you define macro DEBUG_EEPRO100 in eepro100.c, you will get
> debugging messages which show the frames sent and received.
>
> Multicast frames should be received, but I never tested this,
> so maybe there is a bug, and I know that I did not implement
> all functions needed for multicast.
Hello,
I just tried your new version of eepro100.c and can confirm that
multicast reception does work with this version. Found one bug (which
does not prevent it from working): The length of the multicast list
seems have a byte/number confusion. I get:
EE100 set_multicast_list multicast list, 0 entries
EE100 set_multicast_list multicast list, 0 entries
EE100 set_multicast_list multicast list, 6 entries
EE100 set_multicast_list multicast entry 01 00 5e 00 00 01
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast list, 12 entries
EE100 set_multicast_list multicast entry 01 00 5e 00 00 01
EE100 set_multicast_list multicast entry 01 00 5e 00 00 06
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast list, 18 entries
EE100 set_multicast_list multicast entry 01 00 5e 00 00 01
EE100 set_multicast_list multicast entry 01 00 5e 00 00 05
EE100 set_multicast_list multicast entry 01 00 5e 00 00 06
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
EE100 set_multicast_list multicast entry 00 00 00 00 00 00
This patch fixes this:
--- /home/bjorn/tmp/eepro100.c 2007-12-18 14:52:48.000000000 +0100
+++ /usr/local/src/qemu-0.9.0+20070816/hw/eepro100.c 2007-12-18 15:37:40.000000000 +0100
@@ -905,7 +903,7 @@
TRACE(OTHER, logout("configuration: %s\n", nic_dump(&s->configuration[0], 16)));
break;
case CmdMulticastList:
- set_multicast_list(s, s->tx.tbd_array_addr & BITS(13, 0));
+ set_multicast_list(s, (s->tx.tbd_array_addr & BITS(13, 0)) / 6);
break;
case CmdTx:
tx_command(s);
Thanks for your work on this!
Bjørn
--
How can you say that old people are inherently superior to unborn
people
prev parent reply other threads:[~2007-12-18 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 8:52 [Qemu-devel] multicast and the eepro100 driver Jeff Hoare
2007-07-11 17:11 ` Stefan Weil
2007-12-18 14:44 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874peg83l2.fsf@obelix.mork.no \
--to=bmork@dod.no \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).