From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] backends: remove empty trace-events file
Date: Thu, 29 Jun 2017 11:26:22 -0500 [thread overview]
Message-ID: <875e1a54-863c-a632-9cad-9880416d8693@redhat.com> (raw)
In-Reply-To: <20170629162046.4135-1-berrange@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On 06/29/2017 11:20 AM, Daniel P. Berrange wrote:
> The content of the backends/trace-events file was entirely
> removed in
>
> commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6
> Author: Marc-André Lureau <marcandre.lureau@redhat.com>
> Date: Mon May 29 12:39:42 2017 +0400
>
> char: move char devices to chardev/
>
> Leaving the empty file around, causes tracetool to generate
> an empty .dtrace file which makes the dtrace compiler throw
> a syntax error.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> Makefile.objs | 1 -
> backends/trace-events | 0
> 2 files changed, 1 deletion(-)
> delete mode 100644 backends/trace-events
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-06-29 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 16:20 [Qemu-devel] [PATCH] backends: remove empty trace-events file Daniel P. Berrange
2017-06-29 16:26 ` Eric Blake [this message]
2017-06-29 16:30 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2017-07-06 8:32 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875e1a54-863c-a632-9cad-9880416d8693@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).