[Qemu-devel] [PATCH] backends: remove empty trace-events file

[Qemu-devel] [PATCH] backends: remove empty trace-events file

[Daniel P. Berrange]

The content of the backends/trace-events file was entirely
removed in

  commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   Mon May 29 12:39:42 2017 +0400

    char: move char devices to chardev/

Leaving the empty file around, causes tracetool to generate
an empty .dtrace file which makes the dtrace compiler throw
a syntax error.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
 Makefile.objs         | 1 -
 backends/trace-events | 0
 2 files changed, 1 deletion(-)
 delete mode 100644 backends/trace-events

diff --git a/Makefile.objs b/Makefile.objs
index b2e6322..8004d6d 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -122,7 +122,6 @@ trace-events-subdirs += crypto
 trace-events-subdirs += io
 trace-events-subdirs += migration
 trace-events-subdirs += block
-trace-events-subdirs += backends
 trace-events-subdirs += chardev
 trace-events-subdirs += hw/block
 trace-events-subdirs += hw/block/dataplane
diff --git a/backends/trace-events b/backends/trace-events
deleted file mode 100644
index e69de29..0000000
-- 
2.9.4

Re: [Qemu-devel] [PATCH] backends: remove empty trace-events file

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

On 06/29/2017 11:20 AM, Daniel P. Berrange wrote:
> The content of the backends/trace-events file was entirely
> removed in
> 
>   commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6
>   Author: Marc-André Lureau <marcandre.lureau@redhat.com>
>   Date:   Mon May 29 12:39:42 2017 +0400
> 
>     char: move char devices to chardev/
> 
> Leaving the empty file around, causes tracetool to generate
> an empty .dtrace file which makes the dtrace compiler throw
> a syntax error.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  Makefile.objs         | 1 -
>  backends/trace-events | 0
>  2 files changed, 1 deletion(-)
>  delete mode 100644 backends/trace-events

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] backends: remove empty trace-events file

[Philippe Mathieu-Daudé]

On 06/29/2017 01:20 PM, Daniel P. Berrange wrote:
> The content of the backends/trace-events file was entirely
> removed in
> 
>    commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6
>    Author: Marc-André Lureau <marcandre.lureau@redhat.com>
>    Date:   Mon May 29 12:39:42 2017 +0400
> 
>      char: move char devices to chardev/
> 
> Leaving the empty file around, causes tracetool to generate
> an empty .dtrace file which makes the dtrace compiler throw
> a syntax error.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>   Makefile.objs         | 1 -
>   backends/trace-events | 0
>   2 files changed, 1 deletion(-)
>   delete mode 100644 backends/trace-events
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index b2e6322..8004d6d 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -122,7 +122,6 @@ trace-events-subdirs += crypto
>   trace-events-subdirs += io
>   trace-events-subdirs += migration
>   trace-events-subdirs += block
> -trace-events-subdirs += backends
>   trace-events-subdirs += chardev
>   trace-events-subdirs += hw/block
>   trace-events-subdirs += hw/block/dataplane
> diff --git a/backends/trace-events b/backends/trace-events
> deleted file mode 100644
> index e69de29..0000000
> 

Re: [Qemu-devel] [PATCH] backends: remove empty trace-events file

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Thu, Jun 29, 2017 at 05:20:46PM +0100, Daniel P. Berrange wrote:
> The content of the backends/trace-events file was entirely
> removed in
> 
>   commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6
>   Author: Marc-André Lureau <marcandre.lureau@redhat.com>
>   Date:   Mon May 29 12:39:42 2017 +0400
> 
>     char: move char devices to chardev/
> 
> Leaving the empty file around, causes tracetool to generate
> an empty .dtrace file which makes the dtrace compiler throw
> a syntax error.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  Makefile.objs         | 1 -
>  backends/trace-events | 0
>  2 files changed, 1 deletion(-)
>  delete mode 100644 backends/trace-events

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]