From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1C7ACCD1BC for ; Thu, 23 Oct 2025 17:21:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vByzk-0004Tu-O0; Thu, 23 Oct 2025 13:21:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vByze-0004SX-7s for qemu-devel@nongnu.org; Thu, 23 Oct 2025 13:20:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vByzb-0008AT-KR for qemu-devel@nongnu.org; Thu, 23 Oct 2025 13:20:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761240047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YXz1R8r+d7eg20w9hXw17NnYFjuRGU+RuFSStFX4K5g=; b=BjvXq06qI/M2eb21AVEarKXk/Eg+TZfW0shVT1YOGj3WuhYWc8TbiKpruOq1WsJ5Jdws7d Ph2/avEaUTYDkuFR3o5CXBmXxrmbVh5tT42rfqmIP9UVRvhE/RnbCI7JMCBSwfUhnsr7Sh UVLY29Sz/1JFK5F1wuNZzBD5AZuAZ/4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-AHbek06DPAWPNy1dZpTFtA-1; Thu, 23 Oct 2025 13:20:43 -0400 X-MC-Unique: AHbek06DPAWPNy1dZpTFtA-1 X-Mimecast-MFC-AGG-ID: AHbek06DPAWPNy1dZpTFtA_1761240042 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C15F619540D6; Thu, 23 Oct 2025 17:20:41 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.19]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6DCB919540EB; Thu, 23 Oct 2025 17:20:41 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B51DB21E6A27; Thu, 23 Oct 2025 19:20:38 +0200 (CEST) From: Markus Armbruster To: Peter Xu Cc: Markus Armbruster , qemu-devel@nongnu.org, Fabiano Rosas , Juraj Marcin Subject: Re: [PATCH] migration/qmp: Update "resume" flag doc in "migrate" command In-Reply-To: (Peter Xu's message of "Thu, 23 Oct 2025 10:27:23 -0400") References: <20251022190425.2730441-1-peterx@redhat.com> <87cy6eb25c.fsf@pond.sub.org> <87sef94suf.fsf@pond.sub.org> Date: Thu, 23 Oct 2025 19:20:38 +0200 Message-ID: <875xc54jrt.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > On Thu, Oct 23, 2025 at 04:04:40PM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > On Thu, Oct 23, 2025 at 07:47:11AM +0200, Markus Armbruster wrote: >> >> Peter Xu writes: >> >> >> >> > It wasn't obvious how the resume flag should be used when staring at the >> >> > QAPI doc. Enrich it to be crystal clear. >> >> > >> >> > Reported-by: Markus Armbruster >> >> > Signed-off-by: Peter Xu >> >> > --- >> >> > qapi/migration.json | 5 ++++- >> >> > 1 file changed, 4 insertions(+), 1 deletion(-) >> >> > >> >> > diff --git a/qapi/migration.json b/qapi/migration.json >> >> > index be0f3fcc12..48856078db 100644 >> >> > --- a/qapi/migration.json >> >> > +++ b/qapi/migration.json >> >> > @@ -1732,7 +1732,10 @@ >> >> > # @detach: this argument exists only for compatibility reasons and is >> >> > # ignored by QEMU >> >> > # >> >> > -# @resume: resume one paused migration, default "off". (since 3.0) >> >> > +# @resume: when set, resume one paused postcopy migration, using the new >> >> >> >> Scratch "one" unless there can be more than one. >> > >> > Sure. >> > >> >> >> >> > +# URI/channels specified to replace the old/broken channels. The user >> >> > +# should make sure the migration is in "postcopy-paused" state before >> >> > +# the resume request. Default "off". (since 3.0) >> >> > # >> >> > # Features: >> >> > # >> >> >> >> What happens when migration is not in state "postcopy-paused"? >> > >> > The QMP command "migrate" with resume=true set will be rejected, >> > corresponds to: >> > >> > migrate_prepare(): >> > if (s->state != MIGRATION_STATUS_POSTCOPY_PAUSED) { >> > error_setg(errp, "Cannot resume if there is no " >> > "paused migration"); >> > return false; >> > } >> >> Makes sense, thanks! >> >> I'd suggest something like 'Resume fails unless migration is in >> "postcopy-paused" state. (default: false, since 3.0)' > > Since it's still a "migrate" QMP command, should I use "the command will > fail"? I also re-arranged the words slightly.. would below look a better > next version as a whole? > > # @resume: when set, use the new uri/channels specified to resume paused > # postcopy migration. This flag should only be used if the previous > # postcopy migration was interrupted. The command will fail unless > # migration is in "postcopy-paused" state. (default: false, since 3.0) > > Thanks, I like it. Reviewed-by: Markus Armbruster