Re: [PATCH v5 4/9] tests/functional: Add GDB class

["Alex Bennée" <alex.bennee@linaro.org>]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Thu, Oct 02, 2025 at 02:04:27AM +0000, Gustavo Romero wrote:
>> Add GDB class, which provides methods to run GDB commands and capture
>> their output. The GDB class is a wrapper around the pygdbmi module and
>> interacts with GDB via GDB's machine interface (MI).
>> 
>> Acked-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
>> ---
>>  tests/functional/qemu_test/__init__.py |  1 +
>>  tests/functional/qemu_test/gdb.py      | 88 ++++++++++++++++++++++++++
>>  2 files changed, 89 insertions(+)
>>  create mode 100644 tests/functional/qemu_test/gdb.py
>
>
>> diff --git a/tests/functional/qemu_test/gdb.py b/tests/functional/qemu_test/gdb.py
>> new file mode 100644
>> index 0000000000..05e4c29c2a
>> --- /dev/null
>> +++ b/tests/functional/qemu_test/gdb.py
>> @@ -0,0 +1,88 @@
>> +# SPDX-License-Identifier: GPL-2.0-or-later
>> +#
>> +# A simple interface module built around pygdbmi for handling GDB commands.
>> +#
>> +# Copyright (c) 2025 Linaro Limited
>> +#
>> +# Author:
>> +#  Gustavo Romero <gustavo.romero@linaro.org>
>> +#
>> +# This work is licensed under the terms of the GNU GPL, version 2 or
>> +# later.  See the COPYING file in the top-level directory.
>
> Please remove these two lines - they should not be included in any
> newly authored files - SPDX alone is desired.

I can clean that up when I pull this to save another round trip from
Gustavo.

>
> If that is removed, then
>
>  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
>
> With regards,
> Daniel

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro