From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 115FCCAC59A for ; Thu, 18 Sep 2025 14:25:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uzFZL-0000Pk-Pf; Thu, 18 Sep 2025 10:25:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzFZK-0000PU-Dd for qemu-devel@nongnu.org; Thu, 18 Sep 2025 10:25:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzFZH-0001vZ-JE for qemu-devel@nongnu.org; Thu, 18 Sep 2025 10:25:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758205502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=laxQaYG0mwRyW+Ba6dxaGbkq+ycFuzbSnqpofJKWlDY=; b=gjS5oy1Olt8iN6kyApHN3szKp61wv5UKaBP4TGrqeUhhPBNsX19g1/lzSxQD1h9PWsBJLp zdpnzMnBWGrurat6rhQnmRMN6peUwp/L4ERrAfm6RTIoJQEnDJkR59pSG0w5WGBsHXaNzo c1cpnbxzaYjcGVx+1mxCODwKUkJqLSI= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-PKey3XQxPPeNeLle7JcFlw-1; Thu, 18 Sep 2025 10:25:00 -0400 X-MC-Unique: PKey3XQxPPeNeLle7JcFlw-1 X-Mimecast-MFC-AGG-ID: PKey3XQxPPeNeLle7JcFlw_1758205500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B8FD01800286; Thu, 18 Sep 2025 14:24:59 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.9]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 13E1719560B1; Thu, 18 Sep 2025 14:24:58 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 84C0221E6A27; Thu, 18 Sep 2025 16:24:56 +0200 (CEST) From: Markus Armbruster To: Akihiko Odaki Cc: qemu-devel@nongnu.org, marcandre.lureau@redhat.com, berrange@redhat.com Subject: Re: [PATCH v2 06/12] net/slirp: Clean up error reporting In-Reply-To: (Akihiko Odaki's message of "Thu, 18 Sep 2025 21:24:47 +0900") References: <20250917115207.1730186-1-armbru@redhat.com> <20250917115207.1730186-7-armbru@redhat.com> Date: Thu, 18 Sep 2025 16:24:56 +0200 Message-ID: <875xdfaldz.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.005, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Akihiko Odaki writes: > On 2025/09/17 20:52, Markus Armbruster wrote: >> net_slirp_register_poll_sock() and net_slirp_unregister_poll_sock() >> report WSAEventSelect() failure with error_setg(&error_warn, ...). >> error_setg_win32(&error_warn, ...) is undesirable just like >> error_setg(&error_fatal, ...) and error_setg(&error_abort, ...) are. >> Replace by warn_report(). >> The failures should probably be errors, but these functions implement >> callbacks that cannot fail, exit(1) would be too harsh, and silent >> failure we don't want. Thus, warnings. >> Cc: Marc-Andr=C3=A9 Lureau >> Signed-off-by: Markus Armbruster >> Reviewed-by: Marc-Andr=C3=A9 Lureau >> --- >> net/slirp.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> diff --git a/net/slirp.c b/net/slirp.c >> index 9657e86a84..62f2684609 100644 >> --- a/net/slirp.c >> +++ b/net/slirp.c >> @@ -262,7 +262,8 @@ static void net_slirp_register_poll_sock(slirp_os_so= cket fd, void *opaque) >> if (WSAEventSelect(fd, event_notifier_get_handle(&ctxt->notifier), >> FD_READ | FD_ACCEPT | FD_CLOSE | >> FD_CONNECT | FD_WRITE | FD_OOB) !=3D 0) { >> - error_setg_win32(&error_warn, WSAGetLastError(), "failed to WSA= EventSelect()"); >> + warn_report("failed to WSAEventSelect(): %s", >> + g_win32_error_message(WSAGetLastError())); > > https://docs.gtk.org/glib-win32/func.error_message.html says: >> The caller of the function takes ownership of the data, and is >> responsible for freeing it. I'll fix it. Thanks! > >> } >> #endif >> } >> @@ -271,7 +272,8 @@ static void net_slirp_unregister_poll_sock(slirp_os_= socket fd, void *opaque) >> { >> #ifdef WIN32 >> if (WSAEventSelect(fd, NULL, 0) !=3D 0) { >> - error_setg_win32(&error_warn, WSAGetLastError(), "failed to WSA= EventSelect()"); >> + warn_report("failed to WSAEventSelect(): %s", >> + g_win32_error_message(WSAGetLastError())); >> } >> #endif >> }