From: Fabiano Rosas <farosas@suse.de>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC PATCH 3/3] tests/qtest/migration: Change cpu for aarch64
Date: Thu, 31 Jul 2025 10:55:14 -0300	[thread overview]
Message-ID: <875xf84g8t.fsf@suse.de> (raw)
In-Reply-To: <20250731110326.00000140@huawei.com>
Jonathan Cameron via <qemu-devel@nongnu.org> writes:
> On Wed, 30 Jul 2025 17:52:45 -0300
> Fabiano Rosas <farosas@suse.de> wrote:
>
>> Don't use the 'max' cpu for migration testing of aarch64. That cpu
>> does not provide a stable set of features and is expected to break
>> migration from time to time.
>
> Whilst I can see the motivation, doesn't this leave us with a lack of
> converage for new CPU features that are currently only in max?
It does. That's an interesting aspect. It's better to make sure the new
features come with at least some basic migration support off the gate.
I'll add a patch to this series leaving one of the tests with -cpu
max. That should be enough to cover this scenario.
Thanks
>> 
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>>  tests/qtest/migration/framework.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c
>> index f09365d122..6d980b6b51 100644
>> --- a/tests/qtest/migration/framework.c
>> +++ b/tests/qtest/migration/framework.c
>> @@ -317,7 +317,7 @@ int migrate_start(QTestState **from, QTestState **to, const char *uri,
>>          memory_size = "150M";
>>          machine_alias = "virt";
>>          machine_opts = "gic-version=3";
>> -        arch_opts = g_strdup_printf("-cpu max -kernel %s", bootpath);
>> +        arch_opts = g_strdup_printf("-cpu neoverse-n1 -kernel %s", bootpath);
>>          start_address = ARM_TEST_MEM_START;
>>          end_address = ARM_TEST_MEM_END;
>>      } else {
     prev parent reply	other threads:[~2025-07-31 15:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 20:52 [RFC PATCH 0/3] migration: Fix aarch64 cpregs migration Fabiano Rosas
2025-07-30 20:52 ` [RFC PATCH 1/3] target/arm: Fix migration to QEMU 10.1 Fabiano Rosas
2025-07-30 20:52 ` [RFC PATCH 2/3] tests/qtest/migration: Only test aarch64 on TCG Fabiano Rosas
2025-07-31 13:37   ` Peter Maydell
2025-07-31 14:58     ` Mohamed Mediouni
2025-07-30 20:52 ` [RFC PATCH 3/3] tests/qtest/migration: Change cpu for aarch64 Fabiano Rosas
2025-07-31 10:03   ` Jonathan Cameron via
2025-07-31 13:55     ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=875xf84g8t.fsf@suse.de \
    --to=farosas@suse.de \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).