From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
qemu-devel@nongnu.org, "Radoslaw Biernacki" <rad@semihalf.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Brad Smith" <brad@comstyle.com>,
qemu-arm@nongnu.org
Subject: Re: [PATCH v2 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests
Date: Thu, 14 Mar 2024 12:27:53 +0000 [thread overview]
Message-ID: <875xxpgfqu.fsf@draig.linaro.org> (raw)
In-Reply-To: <CAFEAcA8GhAMtvsRE71fybuY90hXBavbXwCrb=-fWGqg8JebTEQ@mail.gmail.com> (Peter Maydell's message of "Thu, 14 Mar 2024 12:14:03 +0000")
Peter Maydell <peter.maydell@linaro.org> writes:
> On Thu, 14 Mar 2024 at 12:11, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> writes:
>>
>> > sbsa-ref is supposed to emulate real hardware so virtio-rng-pci
>> > does not fit here
>>
>> What is real anyway ;-)
>>
>> VirtIO devices exist in real life and I would argue for PCI the device
>> appears very much like a normal PCI device. I could see the argument for
>> avoiding virtio-mmio devices which are a lot more VM-only in flavour.
>
> But our platform for testing virtio-rng-pci should be the 'virt'
> board (and our avocado test for virt does indeed have that device).
> What exactly are we adding by testing it also in sbsa-ref,
> where the typical user will *not* be using it (if they wanted
> a virtio setup they would be using 'virt')?
I assume just ensuring the board has enough entropy to boot cleanly. If
it doesn't need it then it doesn't matter I guess.
>
> thanks
> -- PMM
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2024-03-14 12:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 9:23 [PATCH v2 0/4] tests/avocado: update sbsa-ref firmware to latest Marcin Juszkiewicz
2024-03-14 9:23 ` [PATCH v2 1/4] tests/avocado: update sbsa-ref firmware Marcin Juszkiewicz
2024-03-14 9:23 ` [PATCH v2 2/4] tests/avocado: drop virtio-rng from sbsa-ref tests Marcin Juszkiewicz
2024-03-14 12:11 ` Alex Bennée
2024-03-14 12:14 ` Peter Maydell
2024-03-14 12:27 ` Alex Bennée [this message]
2024-03-14 9:23 ` [PATCH v2 3/4] tests/avocado: use OpenBSD 7.4 for sbsa-ref Marcin Juszkiewicz
2024-03-14 12:14 ` Alex Bennée
2024-03-14 14:28 ` Marcin Juszkiewicz
2024-03-14 14:39 ` Philippe Mathieu-Daudé
2024-03-14 14:56 ` Alex Bennée
2024-03-14 15:45 ` Marcin Juszkiewicz
2024-03-14 9:23 ` [PATCH v2 4/4] tests/avocado: sbsa-ref: add Alpine tests for misc 'max' setup Marcin Juszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xxpgfqu.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=brad@comstyle.com \
--cc=crosa@redhat.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).