* [PATCH] qapi: Belatedly update CompatPolicy documentation for unstable
@ 2023-10-09 11:04 Markus Armbruster
2023-10-09 11:19 ` Philippe Mathieu-Daudé
2023-10-16 10:52 ` Markus Armbruster
0 siblings, 2 replies; 4+ messages in thread
From: Markus Armbruster @ 2023-10-09 11:04 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake
Commit 57df0dff1a1 (qapi: Extend -compat to set policy for unstable
interfaces) neglected to update the "Limitation" paragraph to mention
feature 'unstable' in addition to feature 'deprecated'. Do that now.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/compat.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/compat.json b/qapi/compat.json
index f4c19837eb..42034d9368 100644
--- a/qapi/compat.json
+++ b/qapi/compat.json
@@ -43,8 +43,8 @@
# This is intended for testing users of the management interfaces.
#
# Limitation: covers only syntactic aspects of QMP, i.e. stuff tagged
-# with feature 'deprecated'. We may want to extend it to cover
-# semantic aspects and CLI.
+# with feature 'deprecated' or 'unstable'. We may want to extend it
+# to cover semantic aspects and CLI.
#
# Limitation: deprecated-output policy @hide is not implemented for
# enumeration values. They behave the same as with policy @accept.
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qapi: Belatedly update CompatPolicy documentation for unstable
2023-10-09 11:04 [PATCH] qapi: Belatedly update CompatPolicy documentation for unstable Markus Armbruster
@ 2023-10-09 11:19 ` Philippe Mathieu-Daudé
2023-10-09 11:46 ` Markus Armbruster
2023-10-16 10:52 ` Markus Armbruster
1 sibling, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-09 11:19 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: eblake
On 9/10/23 13:04, Markus Armbruster wrote:
> Commit 57df0dff1a1 (qapi: Extend -compat to set policy for unstable
> interfaces) neglected to update the "Limitation" paragraph to mention
With retrospective, 'experimental' seems more meaningful. Anyway,
too late.
> feature 'unstable' in addition to feature 'deprecated'. Do that now.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/compat.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/compat.json b/qapi/compat.json
> index f4c19837eb..42034d9368 100644
> --- a/qapi/compat.json
> +++ b/qapi/compat.json
> @@ -43,8 +43,8 @@
> # This is intended for testing users of the management interfaces.
> #
> # Limitation: covers only syntactic aspects of QMP, i.e. stuff tagged
> -# with feature 'deprecated'. We may want to extend it to cover
> -# semantic aspects and CLI.
> +# with feature 'deprecated' or 'unstable'. We may want to extend it
> +# to cover semantic aspects and CLI.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qapi: Belatedly update CompatPolicy documentation for unstable
2023-10-09 11:19 ` Philippe Mathieu-Daudé
@ 2023-10-09 11:46 ` Markus Armbruster
0 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2023-10-09 11:46 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-devel, eblake
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 9/10/23 13:04, Markus Armbruster wrote:
>> Commit 57df0dff1a1 (qapi: Extend -compat to set policy for unstable
>> interfaces) neglected to update the "Limitation" paragraph to mention
>
> With retrospective, 'experimental' seems more meaningful. Anyway,
> too late.
Experiments are a major use for interfaces without stability promise,
but there's also debugging aids and such.
>> feature 'unstable' in addition to feature 'deprecated'. Do that now.
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> qapi/compat.json | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/qapi/compat.json b/qapi/compat.json
>> index f4c19837eb..42034d9368 100644
>> --- a/qapi/compat.json
>> +++ b/qapi/compat.json
>> @@ -43,8 +43,8 @@
>> # This is intended for testing users of the management interfaces.
>> #
>> # Limitation: covers only syntactic aspects of QMP, i.e. stuff tagged
>> -# with feature 'deprecated'. We may want to extend it to cover
>> -# semantic aspects and CLI.
>> +# with feature 'deprecated' or 'unstable'. We may want to extend it
>> +# to cover semantic aspects and CLI.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qapi: Belatedly update CompatPolicy documentation for unstable
2023-10-09 11:04 [PATCH] qapi: Belatedly update CompatPolicy documentation for unstable Markus Armbruster
2023-10-09 11:19 ` Philippe Mathieu-Daudé
@ 2023-10-16 10:52 ` Markus Armbruster
1 sibling, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2023-10-16 10:52 UTC (permalink / raw)
To: qemu-devel; +Cc: eblake
Markus Armbruster <armbru@redhat.com> writes:
> Commit 57df0dff1a1 (qapi: Extend -compat to set policy for unstable
> interfaces) neglected to update the "Limitation" paragraph to mention
> feature 'unstable' in addition to feature 'deprecated'. Do that now.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Queued.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-16 11:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-09 11:04 [PATCH] qapi: Belatedly update CompatPolicy documentation for unstable Markus Armbruster
2023-10-09 11:19 ` Philippe Mathieu-Daudé
2023-10-09 11:46 ` Markus Armbruster
2023-10-16 10:52 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).