qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Cc: peterx@redhat.com,  farosas@suse.de,  leobras@redhat.com,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/4] migration: check for rate_limit_max for RATE_LIMIT_DISABLED
Date: Mon, 16 Oct 2023 09:23:16 +0200	[thread overview]
Message-ID: <875y3758uz.fsf@secure.mitica> (raw)
In-Reply-To: <20231011184358.97349-2-elena.ufimtseva@oracle.com> (Elena Ufimtseva's message of "Wed, 11 Oct 2023 11:43:55 -0700")

Elena Ufimtseva <elena.ufimtseva@oracle.com> wrote:
> In migration rate limiting atomic operations are used
> to read the rate limit variables and transferred bytes and
> they are expensive. Check first if rate_limit_max is equal
> to RATE_LIMIT_DISABLED and return false immediately if so.
>
> Note that with this patch we will also will stop flushing
> by not calling qemu_fflush() from migration_transferred_bytes()
> if the migration rate is not exceeded.
> This should be fine since migration thread calls in the loop
> migration_update_counters from migration_rate_limit() that
> calls the migration_transferred_bytes() and flushes there.
>
> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> Reviewed-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

queued.



  reply	other threads:[~2023-10-16  7:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 18:43 [PATCH v2 0/4] multifd: various fixes Elena Ufimtseva
2023-10-11 18:43 ` [PATCH v2 1/4] migration: check for rate_limit_max for RATE_LIMIT_DISABLED Elena Ufimtseva
2023-10-16  7:23   ` Juan Quintela [this message]
2023-10-11 18:43 ` [PATCH v2 2/4] multifd: document packet_len, next_packet_size Elena Ufimtseva
2023-10-11 19:04   ` Fabiano Rosas
2023-10-11 18:43 ` [PATCH v2 3/4] multifd: fix counters in multifd_send_thread Elena Ufimtseva
2023-10-16  7:25   ` Juan Quintela
2023-10-11 18:43 ` [PATCH v2 4/4] multifd: reset next_packet_len after sending pages Elena Ufimtseva
2023-10-16  7:26   ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y3758uz.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=farosas@suse.de \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).