From: Fabiano Rosas <farosas@suse.de>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
libvir-list@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
Peter Xu <peterx@redhat.com>, Eric Blake <eblake@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH 02/26] migration/multifd: Protect accesses to migration_threads
Date: Mon, 24 Jul 2023 10:29:08 -0300 [thread overview]
Message-ID: <875y69zbdn.fsf@suse.de> (raw)
In-Reply-To: <20230724130639.93135-3-quintela@redhat.com>
Juan Quintela <quintela@redhat.com> writes:
> From: Fabiano Rosas <farosas@suse.de>
>
> This doubly linked list is common for all the multifd and migration
> threads so we need to avoid concurrent access.
>
> Add a mutex to protect the data from concurrent access. This fixes a
> crash when removing two MigrationThread objects from the list at the
> same time during cleanup of multifd threads.
>
> Fixes: 671326201d ("migration: Introduce interface query-migrationthreads")
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Message-Id: <20230607161306.31425-3-farosas@suse.de>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Hi Juan,
What about re-enabling the /multifd/tcp/plain/cancel test? You had
mentioned that something else was needed, but never said exactly
what...
I've been doing a lot of migration work recently and all of my branches
have this change and the cancel test enabled. No issues so far.
next prev parent reply other threads:[~2023-07-24 13:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 13:06 [PATCH 00/26] Migration PULL 2023-07-24 Juan Quintela
2023-07-24 13:06 ` [PATCH 01/26] migration/multifd: Rename threadinfo.c functions Juan Quintela
2023-07-24 13:06 ` [PATCH 02/26] migration/multifd: Protect accesses to migration_threads Juan Quintela
2023-07-24 13:29 ` Fabiano Rosas [this message]
2023-07-24 13:06 ` [PATCH 03/26] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" Juan Quintela
2023-07-24 13:06 ` [PATCH 04/26] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter Juan Quintela
2023-07-24 13:06 ` [PATCH 05/26] qapi/migration: Introduce vcpu-dirty-limit parameters Juan Quintela
2023-07-24 13:06 ` [PATCH 06/26] migration: Introduce dirty-limit capability Juan Quintela
2023-07-24 13:06 ` [PATCH 07/26] migration: Refactor auto-converge capability logic Juan Quintela
2023-07-24 13:06 ` [PATCH 08/26] migration: Put the detection logic before auto-converge checking Juan Quintela
2023-07-24 13:06 ` [PATCH 09/26] migration: Implement dirty-limit convergence algo Juan Quintela
2023-07-24 13:06 ` [PATCH 10/26] migration: Extend query-migrate to provide dirty page limit info Juan Quintela
2023-07-24 13:06 ` [PATCH 11/26] migration-test: Be consistent for ppc Juan Quintela
2023-07-24 13:06 ` [PATCH 12/26] migration-test: Make machine_opts regular with other options Juan Quintela
2023-07-24 13:06 ` [PATCH 13/26] migration-test: Create arch_opts Juan Quintela
2023-07-24 13:06 ` [PATCH 14/26] migration-test: machine_opts is really arch specific Juan Quintela
2023-07-24 13:06 ` [PATCH 15/26] migration.json: Don't use space before colon Juan Quintela
2023-07-24 13:06 ` [PATCH 16/26] migration: skipped field is really obsolete Juan Quintela
2023-07-24 13:06 ` [PATCH 17/26] docs/migration: Update postcopy bits Juan Quintela
2023-07-24 13:06 ` [PATCH 18/26] migration: Update error description whenever migration fails Juan Quintela
2023-07-24 13:06 ` [PATCH 19/26] migration: enforce multifd and postcopy preempt to be set before incoming Juan Quintela
2023-07-24 13:06 ` [PATCH 20/26] qtest/migration-tests.c: use "-incoming defer" for postcopy tests Juan Quintela
2023-07-24 13:06 ` [PATCH 21/26] qemu-file: Rename qemu_file_transferred_ fast -> noflush Juan Quintela
2023-07-24 13:06 ` [PATCH 22/26] migration: Change qemu_file_transferred to noflush Juan Quintela
2023-07-24 13:06 ` [PATCH 23/26] qemu_file: Make qemu_file_is_writable() static Juan Quintela
2023-07-24 13:06 ` [PATCH 24/26] qemu-file: Simplify qemu_file_shutdown() Juan Quintela
2023-07-24 13:06 ` [PATCH 25/26] qemu-file: Make qemu_file_get_error_obj() static Juan Quintela
2023-07-24 13:06 ` [PATCH 26/26] migration/rdma: Split qemu_fopen_rdma() into input/output functions Juan Quintela
2023-07-24 13:28 ` [PATCH 00/26] Migration PULL 2023-07-24 Thomas Huth
2023-07-31 6:56 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y69zbdn.fsf@suse.de \
--to=farosas@suse.de \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=leobras@redhat.com \
--cc=libvir-list@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).