From: Juan Quintela <quintela@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, leobras@redhat.com,
peterx@redhat.com, yc-core@yandex-team.ru
Subject: Re: [PATCH 5/5] migration: restore vmstate on migration failure
Date: Thu, 18 May 2023 13:22:11 +0200 [thread overview]
Message-ID: <875y8pevfg.fsf@secure.mitica> (raw)
In-Reply-To: <20230517123752.21615-6-vsementsov@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Wed, 17 May 2023 15:37:52 +0300")
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> 1. Otherwise failed migration just drops guest-panicked state, which is
> not good for management software.
>
> 2. We do keep different paused states like guest-panicked during
> migration with help of global_state state.
>
> 3. We do restore running state on source when migration is cancelled or
> failed.
>
> 4. "postmigrate" state is documented as "guest is paused following a
> successful 'migrate'", so originally it's only for successful path
> and we never documented current behavior.
>
> Let's restore paused states like guest-panicked in case of cancel or
> fail too. Allow same transitions like for inmigrate state.
>
> This commit changes the behavior that was introduced by commit
> 42da5550d6 "migration: set state to post-migrate on failure" and
> provides a bit different fix on related
> https://bugzilla.redhat.com/show_bug.cgi?id=1355683
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2023-05-18 11:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 12:37 [PATCH 0/5] Restore vmstate on cancelled/failed migration Vladimir Sementsov-Ogievskiy
2023-05-17 12:37 ` [PATCH 1/5] runstate: add runstate_get() Vladimir Sementsov-Ogievskiy
2023-05-18 11:13 ` Juan Quintela
2023-05-17 12:37 ` [PATCH 2/5] migration: never fail in global_state_store() Vladimir Sementsov-Ogievskiy
2023-05-18 11:18 ` Juan Quintela
2023-05-18 14:43 ` Vladimir Sementsov-Ogievskiy
2023-05-26 8:28 ` Juan Quintela
2023-05-17 12:37 ` [PATCH 3/5] runstate: drop unused runstate_store() Vladimir Sementsov-Ogievskiy
2023-05-18 11:19 ` Juan Quintela
2023-05-17 12:37 ` [PATCH 4/5] migration: switch from .vm_was_running to .vm_old_state Vladimir Sementsov-Ogievskiy
2023-05-18 11:20 ` Juan Quintela
2023-05-17 12:37 ` [PATCH 5/5] migration: restore vmstate on migration failure Vladimir Sementsov-Ogievskiy
2023-05-18 11:22 ` Juan Quintela [this message]
2023-05-18 11:23 ` [PATCH 0/5] Restore vmstate on cancelled/failed migration Juan Quintela
2023-05-18 14:49 ` Vladimir Sementsov-Ogievskiy
2023-05-26 7:59 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y8pevfg.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=leobras@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).