From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>,
libvir-list@redhat.com, Laurent Vivier <laurent@vivier.eu>,
Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo
Date: Tue, 25 Apr 2023 15:08:28 +0200 [thread overview]
Message-ID: <875y9kun1v.fsf@pond.sub.org> (raw)
In-Reply-To: <CAFEAcA-T7jYeCp9Sqx8nMNeDL2Dr-U0=5FSCyv7QW58Eimto-w@mail.gmail.com> (Peter Maydell's message of "Tue, 25 Apr 2023 13:13:33 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On Tue, 25 Apr 2023 at 13:10, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>> > -# Notes: @singlestep is enabled through the GDB stub
>> > +# Notes: @singlestep is enabled on the command line with
>> > +# '-accel tcg,one-insn-per-tb=on', or with the HMP
>> > +# 'one-insn-per-tb' command.
>>
>> You're deleting "enabled through the GDB stub". Is this one of the
>> misstatements you alluded to in the commit message
>
> Yes -- this field has never been anything to do with
> GDB-enabled singlestep (or for that matter with
> emulation of any guest-CPU architecture singlestep
> functionality). I assume that whoever originally wrote
> that text was confused by the terrible name of the
> command line option/global variable.
Thanks!
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2023-04-25 13:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 16:40 [PATCH v3 00/10] Deprecate/rename singlestep command line option, monitor interfaces Peter Maydell
2023-04-17 16:40 ` [PATCH v3 01/10] make one-insn-per-tb an accel option Peter Maydell
2023-04-17 16:40 ` [PATCH v3 02/10] softmmu: Don't use 'singlestep' global in QMP and HMP commands Peter Maydell
2023-04-20 8:54 ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global Peter Maydell
2023-04-18 8:02 ` Richard Henderson
2023-04-18 8:05 ` Richard Henderson
2023-04-18 9:44 ` Peter Maydell
2023-04-20 8:55 ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 04/10] linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep' Peter Maydell
2023-04-20 9:13 ` Philippe Mathieu-Daudé
2023-04-20 9:19 ` Peter Maydell
2023-04-20 10:05 ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 05/10] bsd-user: " Peter Maydell
2023-04-20 9:13 ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 06/10] Document that -singlestep command line option is deprecated Peter Maydell
2023-04-20 8:56 ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 07/10] accel/tcg: Report one-insn-per-tb in 'info jit', not 'info status' Peter Maydell
2023-04-18 8:06 ` Richard Henderson
2023-04-20 9:02 ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 08/10] hmp: Add 'one-insn-per-tb' command equivalent to 'singlestep' Peter Maydell
2023-04-20 9:03 ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 09/10] qapi/run-state.json: Fix missing newline at end of file Peter Maydell
2023-04-20 9:04 ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo Peter Maydell
2023-04-18 8:08 ` Richard Henderson
2023-04-20 9:05 ` Philippe Mathieu-Daudé
2023-04-24 10:06 ` Peter Maydell
[not found] ` <87jzy18oqv.fsf@pond.sub.org>
2023-04-25 12:13 ` Peter Maydell
2023-04-25 13:08 ` Markus Armbruster [this message]
2023-05-02 10:22 ` [PATCH v3 00/10] Deprecate/rename singlestep command line option, monitor interfaces Peter Maydell
2023-05-02 10:43 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y9kun1v.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=libvir-list@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).