From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51677C77B61 for ; Tue, 25 Apr 2023 13:42:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prIPQ-0004uh-99; Tue, 25 Apr 2023 09:08:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prIPN-0004uT-Va for qemu-devel@nongnu.org; Tue, 25 Apr 2023 09:08:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prIPM-0005MN-0c for qemu-devel@nongnu.org; Tue, 25 Apr 2023 09:08:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682428114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7o6420pqOpbR0e1kPVuQahpzuSrRnYJ8j2ZoE5Wd6vI=; b=OXKCLJzrwSTPdtSL89ejZeW881MMBzEdtA9onoWonSxrgLLZMNj0AgjgeHm4ghC8dgJPIQ Nm+qdlCrXHh1jhORa2zepULPHJ1pM7LiqwpgVNi4TCfZMn/ugUTpkejoVy5vUkG46xS89N KNYb4b1376iPWIjjy/CVKJPRd9r3N9Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-39-1FSx1N8DPE6s7R24VRRlDA-1; Tue, 25 Apr 2023 09:08:30 -0400 X-MC-Unique: 1FSx1N8DPE6s7R24VRRlDA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9CD7B185A78B; Tue, 25 Apr 2023 13:08:29 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7316F2166B3A; Tue, 25 Apr 2023 13:08:29 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 64BD821F1672; Tue, 25 Apr 2023 15:08:28 +0200 (CEST) From: Markus Armbruster To: Peter Maydell Cc: qemu-devel@nongnu.org, Richard Henderson , Warner Losh , Kyle Evans , libvir-list@redhat.com, Laurent Vivier , Eric Blake Subject: Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo References: <20230417164041.684562-1-peter.maydell@linaro.org> <20230417164041.684562-11-peter.maydell@linaro.org> <87jzy18oqv.fsf@pond.sub.org> Date: Tue, 25 Apr 2023 15:08:28 +0200 In-Reply-To: (Peter Maydell's message of "Tue, 25 Apr 2023 13:13:33 +0100") Message-ID: <875y9kun1v.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.171, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Maydell writes: > On Tue, 25 Apr 2023 at 13:10, Markus Armbruster wrote: >> >> Peter Maydell writes: >> >> > -# Notes: @singlestep is enabled through the GDB stub >> > +# Notes: @singlestep is enabled on the command line with >> > +# '-accel tcg,one-insn-per-tb=on', or with the HMP >> > +# 'one-insn-per-tb' command. >> >> You're deleting "enabled through the GDB stub". Is this one of the >> misstatements you alluded to in the commit message > > Yes -- this field has never been anything to do with > GDB-enabled singlestep (or for that matter with > emulation of any guest-CPU architecture singlestep > functionality). I assume that whoever originally wrote > that text was confused by the terrible name of the > command line option/global variable. Thanks! Reviewed-by: Markus Armbruster