From: Markus Armbruster <armbru@redhat.com>
To: Peter Krempa <pkrempa@redhat.com>
Cc: qemu-devel@nongnu.org, "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Eric Blake" <eblake@redhat.com>
Subject: Re: [PATCH] qapi: Add 'acpi' field to 'query-machines' output
Date: Mon, 27 Feb 2023 16:42:54 +0100 [thread overview]
Message-ID: <875ybnp11d.fsf@pond.sub.org> (raw)
In-Reply-To: <c556e203447618f5e1020878b1781428b16ad97e.1677511289.git.pkrempa@redhat.com> (Peter Krempa's message of "Mon, 27 Feb 2023 16:31:39 +0100")
Peter Krempa <pkrempa@redhat.com> writes:
> Report which machine types support ACPI so that management applications
> can properly use the 'acpi' property even on platforms such as ARM where
> support for ACPI depends on the machine type and thus checking presence
> of '-machine acpi=' in 'query-command-line-options' is insufficient.
>
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
[...]
> diff --git a/qapi/machine.json b/qapi/machine.json
> index b9228a5e46..f82a00963b 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -155,6 +155,8 @@
> #
> # @default-ram-id: the default ID of initial RAM memory backend (since 5.2)
> #
> +# @acpi: machine type supports acpi (since 8.0)
supports ACPI
> +#
> # Since: 1.2
> ##
> { 'struct': 'MachineInfo',
> @@ -162,7 +164,7 @@
> '*is-default': 'bool', 'cpu-max': 'int',
> 'hotpluggable-cpus': 'bool', 'numa-mem-supported': 'bool',
> 'deprecated': 'bool', '*default-cpu-type': 'str',
> - '*default-ram-id': 'str' } }
> + '*default-ram-id': 'str', 'acpi': 'bool' } }
>
> ##
> # @query-machines:
With that
Acked-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2023-02-27 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 15:31 [PATCH] qapi: Add 'acpi' field to 'query-machines' output Peter Krempa
2023-02-27 15:42 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ybnp11d.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).