From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: luoyonggang@gmail.com,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 04/10] disas: Clean up CPUDebug initialization
Date: Thu, 17 Sep 2020 18:06:10 +0100 [thread overview]
Message-ID: <875z8cxri5.fsf@linaro.org> (raw)
In-Reply-To: <1eb5fb1b-4341-88e9-16b1-f9db78eceadb@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 15/09/2020 01.02, Richard Henderson wrote:
>> Rename several functions, dropping "generic" and making "host"
>> vs "target" clearer. Make a bunch of functions static that are
>> not used outside this file. Replace INIT_DISASSEMBLE_INFO with
>> a trio of functions.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> include/disas/dis-asm.h | 60 --------
>> disas.c | 326 ++++++++++++++++++----------------------
>> 2 files changed, 148 insertions(+), 238 deletions(-)
>>
>> diff --git a/include/disas/dis-asm.h b/include/disas/dis-asm.h
>> index 9856bf7921..d2418c977e 100644
>> --- a/include/disas/dis-asm.h
>> +++ b/include/disas/dis-asm.h
>> @@ -461,67 +461,7 @@ int print_insn_riscv32 (bfd_vma, disassemble_info*);
>> int print_insn_riscv64 (bfd_vma, disassemble_info*);
>> int print_insn_rx(bfd_vma, disassemble_info *);
>>
>> -#if 0
>> -/* Fetch the disassembler for a given BFD, if that support is available. */
>> -disassembler_ftype disassembler(bfd *);
>> -#endif
>> -
>> \f
>
> By the way, while you're at it, could you please also remove the form
> feed character in this file here? ... that looks really confusing in my
> e-mail client otherwise.
I'm not entirely convinced that is from Richard. I've been seeing rouge
^L and ^M's from all sorts of normally unix clean contributors. I smell
mailing list shenanigans.
--
Alex Bennée
next prev parent reply other threads:[~2020-09-17 17:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 23:02 [PATCH v2 00/10] capstone + disassembler patches Richard Henderson
2020-09-14 23:02 ` [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits Richard Henderson
2020-09-14 23:06 ` Richard Henderson
2020-09-15 6:27 ` Paolo Bonzini
2020-09-15 14:27 ` Richard Henderson
2020-09-15 16:12 ` 罗勇刚(Yonggang Luo)
2020-09-15 16:59 ` Paolo Bonzini
2020-09-15 17:07 ` 罗勇刚(Yonggang Luo)
2020-09-15 17:14 ` Paolo Bonzini
2020-09-15 17:20 ` 罗勇刚(Yonggang Luo)
2020-09-15 16:58 ` Paolo Bonzini
2020-09-15 6:10 ` Thomas Huth
2020-09-14 23:02 ` [PATCH v2 02/10] capstone: Update to upstream "next" branch Richard Henderson
2020-09-14 23:02 ` [PATCH v2 03/10] disas: Move host asm annotations to tb_gen_code Richard Henderson
2020-09-15 16:36 ` Thomas Huth
2020-09-14 23:02 ` [PATCH v2 04/10] disas: Clean up CPUDebug initialization Richard Henderson
2020-09-17 14:39 ` Thomas Huth
2020-09-17 14:50 ` Thomas Huth
2020-09-17 17:06 ` Alex Bennée [this message]
2020-09-17 20:20 ` Richard Henderson
2020-09-14 23:02 ` [PATCH v2 05/10] disas: Use qemu/bswap.h for bfd endian loads Richard Henderson
2020-09-14 23:02 ` [PATCH v2 06/10] disas: Cleanup plugin_disas Richard Henderson
2020-09-14 23:02 ` [PATCH v2 07/10] disas: Configure capstone for aarch64 host without libvixl Richard Henderson
2020-09-17 14:44 ` Thomas Huth
2020-09-14 23:02 ` [PATCH v2 08/10] disas: Split out capstone code to disas/capstone.c Richard Henderson
2020-09-14 23:02 ` [PATCH v2 09/10] disas: Enable capstone disassembly for s390x Richard Henderson
2020-09-17 16:30 ` Thomas Huth
2020-09-14 23:02 ` [PATCH v2 10/10] disas/capstone: Add skipdata hook " Richard Henderson
2020-09-17 16:32 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z8cxri5.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=luoyonggang@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).