From: "Alex Bennée" <alex.bennee@linaro.org>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Robert Foley <robert.foley@linaro.org>,
qemu-devel@nongnu.org, cota@braap.org,
Stefan Hajnoczi <stefanha@redhat.com>,
peter.puhov@linaro.org
Subject: Re: [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.
Date: Mon, 29 Jun 2020 17:04:19 +0100 [thread overview]
Message-ID: <875zb9svss.fsf@linaro.org> (raw)
In-Reply-To: <20200629132640.GN31392@stefanha-x1.localdomain>
Stefan Hajnoczi <stefanha@gmail.com> writes:
> On Fri, Jun 26, 2020 at 01:00:01PM -0400, Robert Foley wrote:
>> This is a cleanup patch to follow-up the patch which introduced TSAN.
>> This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.
>>
>> This does two things:
>> 1. Unrelated ASAN and TSAN code is separate and each function only
>> has arguments that are actually needed.
>> 2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
>> access from within #ifdef CONFIG_TSAN.
>>
>> Signed-off-by: Robert Foley <robert.foley@linaro.org>
>> ---
>> util/coroutine-ucontext.c | 52 +++++++++++++++++++++++++--------------
>> 1 file changed, 34 insertions(+), 18 deletions(-)
>
> Thank you for revisiting this patch after it was applied!
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Who takes care of coroutine patches or should this go via a different
tree?
--
Alex Bennée
next prev parent reply other threads:[~2020-06-29 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 17:00 [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN Robert Foley
2020-06-29 13:26 ` Stefan Hajnoczi
2020-06-29 16:04 ` Alex Bennée [this message]
2020-06-30 8:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zb9svss.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=kwolf@redhat.com \
--cc=peter.puhov@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=robert.foley@linaro.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).