From: Markus Armbruster <armbru@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Cc: den@openvz.org, vsementsov@virtuozzo.com, qemu-devel@nongnu.org,
mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v3] make check-unit: use after free in test-opts-visitor
Date: Wed, 21 Aug 2019 13:25:19 +0200 [thread overview]
Message-ID: <875zmqlq00.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1565024586-387112-1-git-send-email-andrey.shinkevich@virtuozzo.com> (Andrey Shinkevich's message of "Mon, 5 Aug 2019 20:03:06 +0300")
Andrey Shinkevich <andrey.shinkevich@virtuozzo.com> writes:
> In the struct OptsVisitor, the 'repeated_opts' member points to a list
> in the 'unprocessed_opts' hash table after the list has been destroyed.
> A subsequent call to visit_type_int() references the deleted list.
> It results in use-after-free issue reproduced by running the test case
> under the Valgrind: valgrind tests/test-opts-visitor.
> A new mode ListMode::LM_TRAVERSED is declared to mark the list
> traversal completed.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Queued. Thanks!
next prev parent reply other threads:[~2019-08-21 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 17:03 [Qemu-devel] [PATCH v3] make check-unit: use after free in test-opts-visitor Andrey Shinkevich
2019-08-20 15:17 ` Andrey Shinkevich
2019-08-21 11:25 ` Markus Armbruster [this message]
2019-08-21 11:55 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zmqlq00.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).