From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIaS4-0006z0-JA for qemu-devel@nongnu.org; Tue, 15 May 2018 09:57:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIaS1-00014k-EY for qemu-devel@nongnu.org; Tue, 15 May 2018 09:57:16 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:42200) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fIaS1-00014J-6e for qemu-devel@nongnu.org; Tue, 15 May 2018 09:57:13 -0400 Received: by mail-wr0-x243.google.com with SMTP id v5-v6so241780wrf.9 for ; Tue, 15 May 2018 06:57:12 -0700 (PDT) References: <20180514221219.7091-1-richard.henderson@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20180514221219.7091-1-richard.henderson@linaro.org> Date: Tue, 15 May 2018 14:57:10 +0100 Message-ID: <87603pf2dl.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 00/28] softfloat patch roundup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org Richard Henderson writes: > This is my SNaN patch set, Alex's float-float refactor, and a couple > of other random outstanding fpu patches. This has been reordered so > as to be bisectable, since the float-float refactor requires the snan > work to avoid breakage. > > This was built on top of pm215/target-arm.next to make it easier to test. > The whole tree is > > git://github.com/rth7680/qemu.git fpu-roundup I've finished my review pass, looking good. > > Changes since last: > - Use v5 instead of v3, since Alex was up to v4 with float-float. > - Incorporate feedback from pm215. > - Include float128 fix from Petr. > - Include further cleanups for default_nan and silence_nan. > The first of these was inspired by a comment from pm215; > the rest follow as logical extensions. > > > r~ > > > Alex Benn=C3=A9e (4): > target/arm: convert conversion helpers to fpst/ahp_flag > target/arm: squash FZ16 behaviour for conversions > fpu/softfloat: Partial support for ARM Alternative half-precision > fpu/softfloat: re-factor float to float conversions > > Petr Tesarik (1): > fpu/softfloat: Fix conversion from uint64 to float128 > > Richard Henderson (23): > fpu/softfloat: Merge NO_SIGNALING_NANS definitions > fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan > fpu/softfloat: Move softfloat-specialize.h below FloatParts definition > fpu/softfloat: Canonicalize NaN fraction > fpu/softfloat: Introduce parts_is_snan_frac > fpu/softfloat: Replace float_class_dnan with parts_default_nan > fpu/softfloat: Replace float_class_msnan with parts_silence_nan > target/arm: Use floatX_silence_nan when we have already checked for SNaN > target/arm: Remove floatX_maybe_silence_nan from conversions > target/hppa: Remove floatX_maybe_silence_nan from conversions > target/m68k: Use floatX_silence_nan when we have already checked for SN= aN > target/mips: Remove floatX_maybe_silence_nan from conversions > target/riscv: Remove floatX_maybe_silence_nan from conversions > target/s390x: Remove floatX_maybe_silence_nan from conversions > fpu/softfloat: Use float*_silence_nan in propagateFloat*NaN > fpu/softfloat: Remove floatX_maybe_silence_nan > fpu/softfloat: Specialize on snan_bit_is_one > fpu/softfloat: Make is_nan et al available to softfloat-specialize.h > fpu/softfloat: Pass FloatClass to pickNaN > fpu/softfloat: Pass FloatClass to pickNaNMulAdd > fpu/softfloat: Define floatN_default_nan in terms of parts_default_nan > fpu/softfloat: Clean up parts_default_nan > fpu/softfloat: Define floatN_silence_nan in terms of parts_silence_nan > > fpu/softfloat-specialize.h | 691 ++++++++++++++------------------- > include/fpu/softfloat-types.h | 1 + > include/fpu/softfloat.h | 18 +- > target/arm/helper.h | 10 +- > target/arm/translate.h | 12 + > fpu/softfloat.c | 708 ++++++++++++---------------------- > target/arm/helper-a64.c | 7 +- > target/arm/helper.c | 114 +++--- > target/arm/translate-a64.c | 38 +- > target/arm/translate.c | 74 +++- > target/hppa/cpu.c | 1 - > target/hppa/op_helper.c | 2 - > target/m68k/softfloat.c | 3 +- > target/mips/msa_helper.c | 4 - > target/mips/op_helper.c | 2 - > target/ppc/fpu_helper.c | 1 - > target/riscv/fpu_helper.c | 6 +- > target/s390x/fpu_helper.c | 12 +- > target/sh4/cpu.c | 1 - > target/unicore32/cpu.c | 2 - > 20 files changed, 701 insertions(+), 1006 deletions(-) -- Alex Benn=C3=A9e