qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Kevin Wolf <kwolf@redhat.com>,
	qemu-stable@nongnu.org, peterx@redhat.com,
	Max Reitz <mreitz@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all
Date: Fri, 01 Sep 2017 13:41:19 +0200	[thread overview]
Message-ID: <8760d28x40.fsf@secure.laptop> (raw)
In-Reply-To: <20170830100605.22694-1-famz@redhat.com> (Fam Zheng's message of "Wed, 30 Aug 2017 18:06:05 +0800")

Fam Zheng <famz@redhat.com> wrote:
> This fixes the assertion due to op blockers added by BMDS:
>
> block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' failed.
>
> Reproducer: simply start block migration and quit QEMU before it ends.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Fam Zheng <famz@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

This stub stuff is crazy.

Fam, you were right (a.k.a. I was wrong).

Sorry, Juan.

  parent reply	other threads:[~2017-09-01 11:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 10:06 [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all Fam Zheng
2017-08-30 11:49 ` Juan Quintela
2017-08-30 13:18   ` Fam Zheng
2017-08-30 14:04     ` Juan Quintela
2017-08-31  1:19       ` Fam Zheng
2017-09-01 11:41 ` Juan Quintela [this message]
2017-09-05  3:37   ` Fam Zheng
2017-09-05  8:44 ` Kevin Wolf
2017-09-05  8:54   ` Fam Zheng
2017-09-05  9:06     ` Kevin Wolf
2017-09-05 10:05       ` Juan Quintela
2017-09-05 10:28 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-09-05 10:47   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760d28x40.fsf@secure.laptop \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).