From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dQ9Ko-0006yf-Ve for qemu-devel@nongnu.org; Wed, 28 Jun 2017 05:32:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dQ9Kk-0006YP-TD for qemu-devel@nongnu.org; Wed, 28 Jun 2017 05:32:30 -0400 From: Juan Quintela In-Reply-To: <87o9tf5gb8.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Fri, 23 Jun 2017 09:11:39 +0200") References: <149814756006.27338.8723356702388175951.stgit@bahia> <20170622184255.2d44e3bd@bahia.lab.toulouse-stg.fr.ibm.com> <87injo6jla.fsf@secure.mitica> <20170622172555.GE2100@work-vm> <20170622194649.6d251753@bahia.lab.toulouse-stg.fr.ibm.com> <20170622175012.GF2100@work-vm> <87o9tf5gb8.fsf@dusky.pond.sub.org> Reply-To: quintela@redhat.com Date: Wed, 28 Jun 2017 11:32:20 +0200 Message-ID: <8760fg790b.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Maydell , Thomas Huth , QEMU Trivial , QEMU Developers , "Dr. David Alan Gilbert" , Greg Kurz Markus Armbruster wrote: > Peter Maydell writes: > >> On 22 June 2017 at 19:08, Thomas Huth wrote: >>> On 22.06.2017 19:50, Dr. David Alan Gilbert wrote: >>>> Could do; I'm just not finding tiny header files with one or >>>> two entries each that useful. >> >> Well, it means that the bulk of code that doesn't care about the >> types doesn't get its compilation fractionally slowed by having >> to parse the typedef anyway. In general I think we're drifting >> towards "have each .c file get fewer things automatically" rather >> than otherwise (eg more finely focused files rather than stuffing >> everything into qemu-common.h). > > Yes. See also "Our use of #include is undisciplined, and what to do > about it" > Message-ID: <87wpp4m6n1.fsf@blackfin.pond.sub.org> > https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03271.html > > I have some unfinished work towards emptying out qemu-common.h. Need > to find the time to finish it. > > [...] YES!!!!! Once there, we can also do other cleanups. inclufde/sysemu/sysemu.h have things not related at all. I want to get rid of it on migration, because you know, we do zero emulation there, but there are things like "runstate" that are defined there. I removed on that version lots of migration functionality that were there, just from historical reasons, not because they belong there. Later, Juan.