From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAxGW-0002oK-NK for qemu-devel@nongnu.org; Wed, 17 May 2017 07:37:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAxGV-0001H8-W7 for qemu-devel@nongnu.org; Wed, 17 May 2017 07:37:16 -0400 From: Juan Quintela In-Reply-To: <20170516204724.1617-9-eblake@redhat.com> (Eric Blake's message of "Tue, 16 May 2017 15:47:20 -0500") References: <20170516204724.1617-1-eblake@redhat.com> <20170516204724.1617-9-eblake@redhat.com> Reply-To: quintela@redhat.com Date: Wed, 17 May 2017 13:37:02 +0200 Message-ID: <8760gzd89t.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 08/12] dirty-bitmap: Change bdrv_get_dirty() to take bytes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, jsnow@redhat.com, qemu-block@nongnu.org, Fam Zheng , Kevin Wolf , Max Reitz , Jeff Cody , Stefan Hajnoczi , "Dr. David Alan Gilbert" Eric Blake wrote: > Half the callers were already scaling bytes to sectors; the other > half can eventually be simplified to use byte iteration. Both > callers were already using the result as a bool, so make that > explicit. Making the change also makes it easier for a future > dirty-bitmap patch to offload scaling over to the internal hbitmap. > > Remember, asking whether a byte is dirty is effectively asking > whether the entire granularity containing the byte is dirty, since > we only track dirtiness by granularity. > > Signed-off-by: Eric Blake > Reviewed-by: John Snow Reviewed-by: Juan Quintela