From: "Alex Bennée" <alex.bennee@linaro.org>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] docker: Run tests with current user
Date: Fri, 05 May 2017 09:25:36 +0100 [thread overview]
Message-ID: <8760hfoglb.fsf@linaro.org> (raw)
In-Reply-To: <20170505032340.26467-2-famz@redhat.com>
Fam Zheng <famz@redhat.com> writes:
> We've used --add-current-user to create a user in the image, use it to
> run tests, because root has too much priviledge, and can surprise test
> cases.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/docker/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
> index 03eda37..0ed8c3d 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -126,7 +126,7 @@ docker-run: docker-qemu-src
> " COPYING $(EXECUTABLE) to $(IMAGE)"))
> $(call quiet-command, \
> $(SRC_PATH)/tests/docker/docker.py run \
> - -t \
> + $(if $(NOUSER),,-u $(shell id -u)) -t \
> $(if $V,,--rm) \
> $(if $(DEBUG),-i,--net=none) \
> -e TARGET_LIST=$(TARGET_LIST) \
--
Alex Bennée
next prev parent reply other threads:[~2017-05-05 8:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 3:23 [Qemu-devel] [PATCH 0/5] docker: Add test-block Fam Zheng
2017-05-05 3:23 ` [Qemu-devel] [PATCH 1/5] docker: Run tests with current user Fam Zheng
2017-05-05 8:25 ` Alex Bennée [this message]
2017-05-06 16:25 ` Philippe Mathieu-Daudé
2017-05-05 3:23 ` [Qemu-devel] [PATCH 2/5] docker: Add bzip2 and hostname to fedora image Fam Zheng
2017-05-05 8:25 ` Alex Bennée
2017-05-06 16:34 ` Philippe Mathieu-Daudé
2017-05-05 3:23 ` [Qemu-devel] [PATCH 3/5] docker: Use unconfined security profile Fam Zheng
2017-05-05 8:27 ` Alex Bennée
2017-05-05 9:12 ` Fam Zheng
2017-05-06 16:33 ` Philippe Mathieu-Daudé
2017-05-05 3:23 ` [Qemu-devel] [PATCH 4/5] docker: Add libaio to fedora image Fam Zheng
2017-05-05 8:27 ` Alex Bennée
2017-05-06 16:26 ` Philippe Mathieu-Daudé
2017-05-05 3:23 ` [Qemu-devel] [PATCH 5/5] docker: Add test-block Fam Zheng
2017-05-05 8:28 ` Alex Bennée
2017-05-05 8:55 ` Fam Zheng
2017-05-08 15:11 ` Yash Mankad
2017-05-08 15:52 ` Daniel P. Berrange
2017-05-05 7:44 ` [Qemu-devel] [PATCH 0/5] " Paolo Bonzini
2017-05-05 8:05 ` Fam Zheng
2017-05-05 8:07 ` Paolo Bonzini
2017-05-05 8:52 ` Fam Zheng
2017-05-08 15:55 ` Daniel P. Berrange
2017-05-08 16:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760hfoglb.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).