From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1bAE-0000kA-ND for qemu-devel@nongnu.org; Wed, 25 Nov 2015 09:35:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1bA8-0002fS-F1 for qemu-devel@nongnu.org; Wed, 25 Nov 2015 09:35:18 -0500 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:38788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1bA8-0002fL-3p for qemu-devel@nongnu.org; Wed, 25 Nov 2015 09:35:12 -0500 Received: by wmec201 with SMTP id c201so72740593wme.1 for ; Wed, 25 Nov 2015 06:35:11 -0800 (PST) References: <1447946528-1533-1-git-send-email-eric.auger@linaro.org> <1447946528-1533-2-git-send-email-eric.auger@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1447946528-1533-2-git-send-email-eric.auger@linaro.org> Date: Wed, 25 Nov 2015 14:35:09 +0000 Message-ID: <87610qywo2.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RESEND RFC 1/6] hw/vfio/platform: amd-xgbe device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger Cc: peter.maydell@linaro.org, eric.auger@st.com, thomas.lendacky@amd.com, patches@linaro.org, qemu-devel@nongnu.org, alex.williamson@redhat.com, qemu-arm@nongnu.org, suravee.suthikulpanit@amd.com, pbonzini@redhat.com, b.reynal@virtualopensystems.com, christoffer.dall@linaro.org Eric Auger writes: > This patch introduces the amd-xgbe VFIO platform device. It > allows the guest to do passthrough on a device exposing an > "amd,xgbe-seattle-v1a" compat string. > > Signed-off-by: Eric Auger Reviewed-by: Alex Bennée > --- > hw/vfio/Makefile.objs | 1 + > hw/vfio/amd-xgbe.c | 55 +++++++++++++++++++++++++++++++++++++++++ > include/hw/vfio/vfio-amd-xgbe.h | 51 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 107 insertions(+) > create mode 100644 hw/vfio/amd-xgbe.c > create mode 100644 include/hw/vfio/vfio-amd-xgbe.h > > diff --git a/hw/vfio/Makefile.objs b/hw/vfio/Makefile.objs > index d324863..ceddbb8 100644 > --- a/hw/vfio/Makefile.objs > +++ b/hw/vfio/Makefile.objs > @@ -3,4 +3,5 @@ obj-$(CONFIG_SOFTMMU) += common.o > obj-$(CONFIG_PCI) += pci.o pci-quirks.o > obj-$(CONFIG_SOFTMMU) += platform.o > obj-$(CONFIG_SOFTMMU) += calxeda-xgmac.o > +obj-$(CONFIG_SOFTMMU) += amd-xgbe.o > endif > diff --git a/hw/vfio/amd-xgbe.c b/hw/vfio/amd-xgbe.c > new file mode 100644 > index 0000000..53451eb > --- /dev/null > +++ b/hw/vfio/amd-xgbe.c > @@ -0,0 +1,55 @@ > +/* > + * AMD XGBE VFIO device > + * > + * Copyright Linaro Limited, 2015 > + * > + * Authors: > + * Eric Auger > + * > + * This work is licensed under the terms of the GNU GPL, version 2. See > + * the COPYING file in the top-level directory. > + * > + */ > + > +#include "hw/vfio/vfio-amd-xgbe.h" > + > +static void amd_xgbe_realize(DeviceState *dev, Error **errp) > +{ > + VFIOPlatformDevice *vdev = VFIO_PLATFORM_DEVICE(dev); > + VFIOAmdXgbeDeviceClass *k = VFIO_AMD_XGBE_DEVICE_GET_CLASS(dev); > + > + vdev->compat = g_strdup("amd,xgbe-seattle-v1a"); > + > + k->parent_realize(dev, errp); > +} > + > +static const VMStateDescription vfio_platform_amd_xgbe_vmstate = { > + .name = TYPE_VFIO_AMD_XGBE, > + .unmigratable = 1, > +}; > + > +static void vfio_amd_xgbe_class_init(ObjectClass *klass, void *data) > +{ > + DeviceClass *dc = DEVICE_CLASS(klass); > + VFIOAmdXgbeDeviceClass *vcxc = > + VFIO_AMD_XGBE_DEVICE_CLASS(klass); > + vcxc->parent_realize = dc->realize; > + dc->realize = amd_xgbe_realize; > + dc->desc = "VFIO AMD XGBE"; > + dc->vmsd = &vfio_platform_amd_xgbe_vmstate; > +} > + > +static const TypeInfo vfio_amd_xgbe_dev_info = { > + .name = TYPE_VFIO_AMD_XGBE, > + .parent = TYPE_VFIO_PLATFORM, > + .instance_size = sizeof(VFIOAmdXgbeDevice), > + .class_init = vfio_amd_xgbe_class_init, > + .class_size = sizeof(VFIOAmdXgbeDeviceClass), > +}; > + > +static void register_amd_xgbe_dev_type(void) > +{ > + type_register_static(&vfio_amd_xgbe_dev_info); > +} > + > +type_init(register_amd_xgbe_dev_type) > diff --git a/include/hw/vfio/vfio-amd-xgbe.h b/include/hw/vfio/vfio-amd-xgbe.h > new file mode 100644 > index 0000000..9fff65e > --- /dev/null > +++ b/include/hw/vfio/vfio-amd-xgbe.h > @@ -0,0 +1,51 @@ > +/* > + * VFIO AMD XGBE device > + * > + * Copyright Linaro Limited, 2015 > + * > + * Authors: > + * Eric Auger > + * > + * This work is licensed under the terms of the GNU GPL, version 2. See > + * the COPYING file in the top-level directory. > + * > + */ > + > +#ifndef HW_VFIO_VFIO_AMD_XGBE_H > +#define HW_VFIO_VFIO_AMD_XGBE_H > + > +#include "hw/vfio/vfio-platform.h" > + > +#define TYPE_VFIO_AMD_XGBE "vfio-amd-xgbe" > + > +/** > + * This device exposes: > + * - 5 MMIO regions: MAC, PCS, SerDes Rx/Tx regs, > + SerDes Integration Registers 1/2 & 2/2 > + * - 2 level sensitive IRQs and optional DMA channel IRQs > + */ > +struct VFIOAmdXgbeDevice { > + VFIOPlatformDevice vdev; > +}; > + > +typedef struct VFIOAmdXgbeDevice VFIOAmdXgbeDevice; > + > +struct VFIOAmdXgbeDeviceClass { > + /*< private >*/ > + VFIOPlatformDeviceClass parent_class; > + /*< public >*/ > + DeviceRealize parent_realize; > +}; > + > +typedef struct VFIOAmdXgbeDeviceClass VFIOAmdXgbeDeviceClass; > + > +#define VFIO_AMD_XGBE_DEVICE(obj) \ > + OBJECT_CHECK(VFIOAmdXgbeDevice, (obj), TYPE_VFIO_AMD_XGBE) > +#define VFIO_AMD_XGBE_DEVICE_CLASS(klass) \ > + OBJECT_CLASS_CHECK(VFIOAmdXgbeDeviceClass, (klass), \ > + TYPE_VFIO_AMD_XGBE) > +#define VFIO_AMD_XGBE_DEVICE_GET_CLASS(obj) \ > + OBJECT_GET_CLASS(VFIOAmdXgbeDeviceClass, (obj), \ > + TYPE_VFIO_AMD_XGBE) > + > +#endif -- Alex Bennée