From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAcWk-0000Es-RP for qemu-devel@nongnu.org; Fri, 25 Jul 2014 06:15:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAcWc-0007tp-OR for qemu-devel@nongnu.org; Fri, 25 Jul 2014 06:15:02 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:45168 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAcWc-0007tV-I8 for qemu-devel@nongnu.org; Fri, 25 Jul 2014 06:14:54 -0400 References: <1406217175-30267-1-git-send-email-alex.bennee@linaro.org> <1406217175-30267-3-git-send-email-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= Date: Fri, 25 Jul 2014 11:15:12 +0100 In-reply-to: Message-ID: <8761ilhhg6.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/3] target-arm: A64: fix TLB flush instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Richard Henderson Peter Maydell writes: > On 24 July 2014 16:52, Alex Bennée wrote: >> +/* See: D4.7.2 TLB maintenance requirements and the TLB maintenance instructions >> + * Page D4-1736 (DDI0487A.b) "For TLB maintenance instructions that >> + * take an address, the maintenance of VA[63:56] is interpreted as >> + * being the same as the maintenance of VA[55]" >> + */ > > I'd rather we didn't quote this bit of the ARM ARM, because it's > obviously mangled (I'm pretty sure it should say "the value of > VA[..]"). Is it OK to still reference the ARM ARM because otherwise the sign extension would look a little weird without context (although obviously we have a commit message to say we fixed something). > > Otherwise > Reviewed-by: Peter Maydell > > thanks > -- PMM -- Alex Bennée