From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk8jL-00049U-7q for qemu-devel@nongnu.org; Tue, 13 May 2014 05:10:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wk8jF-0008OC-Jy for qemu-devel@nongnu.org; Tue, 13 May 2014 05:10:35 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:60953 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wk8jF-0008Nx-Eg for qemu-devel@nongnu.org; Tue, 13 May 2014 05:10:29 -0400 References: <1399938424-6703-1-git-send-email-rth@twiddle.net> <1399938424-6703-3-git-send-email-rth@twiddle.net> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1399938424-6703-3-git-send-email-rth@twiddle.net> Date: Tue, 13 May 2014 10:10:36 +0100 Message-ID: <8761la82nn.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 02/10] tcg: Invert the inclusion of helper.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, aurelien@aurel32.net Richard Henderson writes: > Rather than include helper.h with N values of GEN_HELPER, include a > secondary file that sets up the macros to include helper.h. This > minimizes the files that must be rebuilt when changing the macros > for file N. > > Signed-off-by: Richard Henderson > --- > include/exec/helper-gen.h | 92 +++++++++++++++++ > include/exec/{def-helper.h => helper-head.h} | 144 +-------------------------- > include/exec/helper-proto.h | 38 +++++++ > include/exec/helper-tcg.h | 35 +++++++ I still find the macro gymnastics of the helper generators a pain because hitting "find" on gen_helper_foo doesn't lead you anywhere useful but I guess that's the price you pay for using macros. Reviewed-by: Alex Bennée -- Alex Bennée