qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Mohamad Gebai <mohamad.gebai@polymtl.ca>,
	mohamad.gebai@gmail.com, qemu-devel@nongnu.org,
	vilanova@ac.upc.edu
Subject: Re: [Qemu-devel] [PATCH] trace: teach lttng backend to use format strings
Date: Tue, 25 Mar 2014 14:49:42 +0000	[thread overview]
Message-ID: <8761n2nxix.fsf@linaro.org> (raw)
In-Reply-To: <20140325095627.GO17172@stefanha-thinkpad.redhat.com>


Stefan Hajnoczi <stefanha@redhat.com> writes:

> On Mon, Mar 24, 2014 at 05:04:54PM +0000, alex.bennee@linaro.org wrote:
>> From: Alex Bennée <alex.bennee@linaro.org>
>> 
>> This makes the UST backend pay attention to the format string arguments
>> that are defined when defining payload data. With this you can now
>> ensure integers are reported in hex mode if you want.
>> 
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  scripts/tracetool/__init__.py    | 13 +++++++++++--
>>  scripts/tracetool/backend/ust.py | 16 ++++++++++++----
>>  2 files changed, 23 insertions(+), 6 deletions(-)
>
> How are strings handled, can LTTng copy them from the QEMU process'
> memory space?

lttng provides ctf_string for passing strings to the payload. But I
wouldn't expect to use them for the result of format string calculations
as that would defeat the point of the low impact tracing.

There are a number of trace-events that pass strings for various things.
I've not actually experimented with the output of any of them though.


>
> Stefan

-- 
Alex Bennée

  reply	other threads:[~2014-03-25 14:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 17:04 [Qemu-devel] [PATCH] trace: teach lttng backend to use format strings alex.bennee
2014-03-24 17:35 ` alex.bennee
2014-03-24 17:42   ` Eric Blake
2014-03-27  8:42   ` Stefan Hajnoczi
2014-03-25  9:56 ` Stefan Hajnoczi
2014-03-25 14:49   ` Alex Bennée [this message]
2014-03-26  8:27     ` Stefan Hajnoczi
2014-03-26 15:45       ` Mohamad Gebai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761n2nxix.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=mohamad.gebai@gmail.com \
    --cc=mohamad.gebai@polymtl.ca \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).