[Qemu-devel] [PATCH 0/2] MAINTAINERS: QMP: entry update and new maintainers

[Qemu-devel] [PATCH 0/2] MAINTAINERS: QMP: entry update and new maintainers

[Luiz Capitulino]

Hi,

This is an small update on QMP/HMP/QAPI mainternership. Please, check
individual patches for details.

Luiz Capitulino (2):
  MAINTAINERS: new maintainers for qapi-schema.json
  MAINTAINERS: split Monitor (QMP/HMP) entry

 MAINTAINERS | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

-- 
1.8.1.4

[Qemu-devel] [PATCH 1/2] MAINTAINERS: new maintainers for qapi-schema.json

[Luiz Capitulino]

I'm facing two problems lately wrt QMP patch review: increasingly
lack of bandwidth and lack of background in so many different areas
that are getting new QMP commands almost every week.

In order to help me mitigate this problem, I'm adding Eric and Markus
(besides me) as maintainers of the qapi-schema.json file.

Markus has been an old timer reviewer. Eric is being the most active
and prolific reviewer of QMP patches for some time now.

I believe Markus and Eric will keep doing their work as before, but
starting now I'll require the ACK of at least one of them before
appling a patch/series that touches the qapi-schema.json file.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index be02724..432185a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -706,6 +706,13 @@ F: nbd.*
 F: qemu-nbd.c
 T: git git://github.com/bonzini/qemu.git nbd-next
 
+QAPI Schema
+M: Eric Blake <eblake@redhat.com>
+M: Luiz Capitulino <lcapitulino@redhat.com>
+M: Markus Armbruster <armbru@redhat.com>
+S: Supported
+F: qapi-schema.json
+
 SLIRP
 M: Jan Kiszka <jan.kiszka@siemens.com>
 S: Maintained
-- 
1.8.1.4

[Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

[Luiz Capitulino]

This entry doesn't reflect reality for a few years now. This commit
splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped
as a maintainer.

This is what we have been for the last few years. Also, it's going
to help me to offload some of this work to someone else in the near
future.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 MAINTAINERS | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 432185a..45f2e68 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -685,11 +685,12 @@ M: Anthony Liguori <aliguori@us.ibm.com>
 S: Supported
 F: vl.c
 
-Monitor (QMP/HMP)
+Human Monitor (HMP)
 M: Luiz Capitulino <lcapitulino@redhat.com>
-M: Markus Armbruster <armbru@redhat.com>
 S: Supported
 F: monitor.c
+F: hmp.c
+F: hmp-commands.hx
 
 Network device layer
 M: Anthony Liguori <aliguori@us.ibm.com>
@@ -706,6 +707,11 @@ F: nbd.*
 F: qemu-nbd.c
 T: git git://github.com/bonzini/qemu.git nbd-next
 
+QAPI
+M: Luiz Capitulino <lcapitulino@redhat.com>
+S: Supported
+F: qapi/
+
 QAPI Schema
 M: Eric Blake <eblake@redhat.com>
 M: Luiz Capitulino <lcapitulino@redhat.com>
@@ -713,6 +719,13 @@ M: Markus Armbruster <armbru@redhat.com>
 S: Supported
 F: qapi-schema.json
 
+QMP
+M: Luiz Capitulino <lcapitulino@redhat.com>
+S: Supported
+F: qmp.c
+F: monitor.c
+F: qmp-commands.hx
+
 SLIRP
 M: Jan Kiszka <jan.kiszka@siemens.com>
 S: Maintained
-- 
1.8.1.4

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

On 06/03/2013 11:17 AM, Luiz Capitulino wrote:
> This entry doesn't reflect reality for a few years now. This commit
> splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped
> as a maintainer.
> 
> This is what we have been for the last few years. Also, it's going
> to help me to offload some of this work to someone else in the near
> future.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  MAINTAINERS | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)

>  QAPI Schema
>  M: Eric Blake <eblake@redhat.com>
>  M: Luiz Capitulino <lcapitulino@redhat.com>
> @@ -713,6 +719,13 @@ M: Markus Armbruster <armbru@redhat.com>
>  S: Supported
>  F: qapi-schema.json
>  
> +QMP
> +M: Luiz Capitulino <lcapitulino@redhat.com>
> +S: Supported
> +F: qmp.c
> +F: monitor.c
> +F: qmp-commands.hx

Do we want QMP/* lumped into this category?  For that matter, should
QMP/qmp-events.txt be included as part of QAPI Schema?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

Re: [Qemu-devel] [PATCH 0/2] MAINTAINERS: QMP: entry update and new maintainers

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

On 06/03/2013 11:17 AM, Luiz Capitulino wrote:
> Hi,
> 
> This is an small update on QMP/HMP/QAPI mainternership. Please, check
> individual patches for details.
> 
> Luiz Capitulino (2):
>   MAINTAINERS: new maintainers for qapi-schema.json
>   MAINTAINERS: split Monitor (QMP/HMP) entry

Series: Reviewed-by: Eric Blake <eblake@redhat.com>

But see questions about whether 2/2 missed some files.

Also, be aware that I'm on vacation June 6-26, so I won't be able to do
much with my increased responsibility until after that point.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

[Luiz Capitulino]

On Mon, 03 Jun 2013 11:24:58 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 06/03/2013 11:17 AM, Luiz Capitulino wrote:
> > This entry doesn't reflect reality for a few years now. This commit
> > splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped
> > as a maintainer.
> > 
> > This is what we have been for the last few years. Also, it's going
> > to help me to offload some of this work to someone else in the near
> > future.
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  MAINTAINERS | 17 +++++++++++++++--
> >  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> >  QAPI Schema
> >  M: Eric Blake <eblake@redhat.com>
> >  M: Luiz Capitulino <lcapitulino@redhat.com>
> > @@ -713,6 +719,13 @@ M: Markus Armbruster <armbru@redhat.com>
> >  S: Supported
> >  F: qapi-schema.json
> >  
> > +QMP
> > +M: Luiz Capitulino <lcapitulino@redhat.com>
> > +S: Supported
> > +F: qmp.c
> > +F: monitor.c
> > +F: qmp-commands.hx
> 
> Do we want QMP/* lumped into this category?  For that matter, should
> QMP/qmp-events.txt be included as part of QAPI Schema?

Yes, for both questions. I've fixed it for v2, but I didn't include
QMP/qmp-events.txt in the QAPI Schema entry cause it would be a bit
confusing. We should move the events to the schema file soon, anyway.

Re: [Qemu-devel] [PATCH 0/2] MAINTAINERS: QMP: entry update and new maintainers

[Luiz Capitulino]

On Mon, 03 Jun 2013 11:27:51 -0600
Eric Blake <eblake@redhat.com> wrote:

> On 06/03/2013 11:17 AM, Luiz Capitulino wrote:
> > Hi,
> > 
> > This is an small update on QMP/HMP/QAPI mainternership. Please, check
> > individual patches for details.
> > 
> > Luiz Capitulino (2):
> >   MAINTAINERS: new maintainers for qapi-schema.json
> >   MAINTAINERS: split Monitor (QMP/HMP) entry
> 
> Series: Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> But see questions about whether 2/2 missed some files.

Thanks.

> Also, be aware that I'm on vacation June 6-26, so I won't be able to do
> much with my increased responsibility until after that point.

Enjoy! :)

Re: [Qemu-devel] [PATCH 0/2] MAINTAINERS: QMP: entry update and new maintainers

[Anthony Liguori]

Luiz Capitulino <lcapitulino@redhat.com> writes:

> Hi,
>
> This is an small update on QMP/HMP/QAPI mainternership. Please, check
> individual patches for details.

Acked-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

>
> Luiz Capitulino (2):
>   MAINTAINERS: new maintainers for qapi-schema.json
>   MAINTAINERS: split Monitor (QMP/HMP) entry
>
>  MAINTAINERS | 24 ++++++++++++++++++++++--
>  1 file changed, 22 insertions(+), 2 deletions(-)
>
> -- 
> 1.8.1.4

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

[Paolo Bonzini]

Il 03/06/2013 19:17, Luiz Capitulino ha scritto:
> This entry doesn't reflect reality for a few years now. This commit
> splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped
> as a maintainer.
> 
> This is what we have been for the last few years. Also, it's going
> to help me to offload some of this work to someone else in the near
> future.
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  MAINTAINERS | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 432185a..45f2e68 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -685,11 +685,12 @@ M: Anthony Liguori <aliguori@us.ibm.com>
>  S: Supported
>  F: vl.c
>  
> -Monitor (QMP/HMP)
> +Human Monitor (HMP)
>  M: Luiz Capitulino <lcapitulino@redhat.com>
> -M: Markus Armbruster <armbru@redhat.com>
>  S: Supported
>  F: monitor.c
> +F: hmp.c
> +F: hmp-commands.hx
>  
>  Network device layer
>  M: Anthony Liguori <aliguori@us.ibm.com>
> @@ -706,6 +707,11 @@ F: nbd.*
>  F: qemu-nbd.c
>  T: git git://github.com/bonzini/qemu.git nbd-next
>  
> +QAPI
> +M: Luiz Capitulino <lcapitulino@redhat.com>

Mike Roth too, perhaps?

Paolo

> +S: Supported
> +F: qapi/
> +
>  QAPI Schema
>  M: Eric Blake <eblake@redhat.com>
>  M: Luiz Capitulino <lcapitulino@redhat.com>
> @@ -713,6 +719,13 @@ M: Markus Armbruster <armbru@redhat.com>
>  S: Supported
>  F: qapi-schema.json
>  
> +QMP
> +M: Luiz Capitulino <lcapitulino@redhat.com>
> +S: Supported
> +F: qmp.c
> +F: monitor.c
> +F: qmp-commands.hx
> +
>  SLIRP
>  M: Jan Kiszka <jan.kiszka@siemens.com>
>  S: Maintained
> 

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

[Luiz Capitulino]

On Mon, 03 Jun 2013 21:13:30 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 03/06/2013 19:17, Luiz Capitulino ha scritto:
> > This entry doesn't reflect reality for a few years now. This commit
> > splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped
> > as a maintainer.
> > 
> > This is what we have been for the last few years. Also, it's going
> > to help me to offload some of this work to someone else in the near
> > future.
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  MAINTAINERS | 17 +++++++++++++++--
> >  1 file changed, 15 insertions(+), 2 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 432185a..45f2e68 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -685,11 +685,12 @@ M: Anthony Liguori <aliguori@us.ibm.com>
> >  S: Supported
> >  F: vl.c
> >  
> > -Monitor (QMP/HMP)
> > +Human Monitor (HMP)
> >  M: Luiz Capitulino <lcapitulino@redhat.com>
> > -M: Markus Armbruster <armbru@redhat.com>
> >  S: Supported
> >  F: monitor.c
> > +F: hmp.c
> > +F: hmp-commands.hx
> >  
> >  Network device layer
> >  M: Anthony Liguori <aliguori@us.ibm.com>
> > @@ -706,6 +707,11 @@ F: nbd.*
> >  F: qemu-nbd.c
> >  T: git git://github.com/bonzini/qemu.git nbd-next
> >  
> > +QAPI
> > +M: Luiz Capitulino <lcapitulino@redhat.com>
> 
> Mike Roth too, perhaps?

I'd like to, but last time I asked he sort of refused :)

Michael, can I add you?

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

[mdroth]

On Mon, Jun 03, 2013 at 03:54:48PM -0400, Luiz Capitulino wrote:
> On Mon, 03 Jun 2013 21:13:30 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> > Il 03/06/2013 19:17, Luiz Capitulino ha scritto:
> > > This entry doesn't reflect reality for a few years now. This commit
> > > splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped
> > > as a maintainer.
> > > 
> > > This is what we have been for the last few years. Also, it's going
> > > to help me to offload some of this work to someone else in the near
> > > future.
> > > 
> > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > > ---
> > >  MAINTAINERS | 17 +++++++++++++++--
> > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 432185a..45f2e68 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -685,11 +685,12 @@ M: Anthony Liguori <aliguori@us.ibm.com>
> > >  S: Supported
> > >  F: vl.c
> > >  
> > > -Monitor (QMP/HMP)
> > > +Human Monitor (HMP)
> > >  M: Luiz Capitulino <lcapitulino@redhat.com>
> > > -M: Markus Armbruster <armbru@redhat.com>
> > >  S: Supported
> > >  F: monitor.c
> > > +F: hmp.c
> > > +F: hmp-commands.hx
> > >  
> > >  Network device layer
> > >  M: Anthony Liguori <aliguori@us.ibm.com>
> > > @@ -706,6 +707,11 @@ F: nbd.*
> > >  F: qemu-nbd.c
> > >  T: git git://github.com/bonzini/qemu.git nbd-next
> > >  
> > > +QAPI
> > > +M: Luiz Capitulino <lcapitulino@redhat.com>
> > 
> > Mike Roth too, perhaps?
> 
> I'd like to, but last time I asked he sort of refused :)
> 
> Michael, can I add you?
> 

Haha, well, I think the discussion back then was whether I should send
QAPI pulls, and I was of the mindset that we should keep sending those
through the QMP tree since most QAPI changes were in support of QMP.

According to the MAINTAINERS documentation though, M: is meant to be
"a set of names that developers can consult when they have a question
about a particular subset and also to provide a set of names to be
CC'd when submitting a patch to obtain appropriate review.", so if
that's the case I'd be happy to add my name and help in that regard.

Re: [Qemu-devel] [PATCH 2/2] MAINTAINERS: split Monitor (QMP/HMP) entry

[Luiz Capitulino]

On Mon, 3 Jun 2013 15:05:03 -0500
mdroth <mdroth@linux.vnet.ibm.com> wrote:

> On Mon, Jun 03, 2013 at 03:54:48PM -0400, Luiz Capitulino wrote:
> > On Mon, 03 Jun 2013 21:13:30 +0200
> > Paolo Bonzini <pbonzini@redhat.com> wrote:
> > 
> > > Il 03/06/2013 19:17, Luiz Capitulino ha scritto:
> > > > This entry doesn't reflect reality for a few years now. This commit
> > > > splits it into Human Monitor (HMP), QAPI and QMP. Markus is dropped
> > > > as a maintainer.
> > > > 
> > > > This is what we have been for the last few years. Also, it's going
> > > > to help me to offload some of this work to someone else in the near
> > > > future.
> > > > 
> > > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > > > ---
> > > >  MAINTAINERS | 17 +++++++++++++++--
> > > >  1 file changed, 15 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 432185a..45f2e68 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -685,11 +685,12 @@ M: Anthony Liguori <aliguori@us.ibm.com>
> > > >  S: Supported
> > > >  F: vl.c
> > > >  
> > > > -Monitor (QMP/HMP)
> > > > +Human Monitor (HMP)
> > > >  M: Luiz Capitulino <lcapitulino@redhat.com>
> > > > -M: Markus Armbruster <armbru@redhat.com>
> > > >  S: Supported
> > > >  F: monitor.c
> > > > +F: hmp.c
> > > > +F: hmp-commands.hx
> > > >  
> > > >  Network device layer
> > > >  M: Anthony Liguori <aliguori@us.ibm.com>
> > > > @@ -706,6 +707,11 @@ F: nbd.*
> > > >  F: qemu-nbd.c
> > > >  T: git git://github.com/bonzini/qemu.git nbd-next
> > > >  
> > > > +QAPI
> > > > +M: Luiz Capitulino <lcapitulino@redhat.com>
> > > 
> > > Mike Roth too, perhaps?
> > 
> > I'd like to, but last time I asked he sort of refused :)
> > 
> > Michael, can I add you?
> > 
> 
> Haha, well, I think the discussion back then was whether I should send
> QAPI pulls, and I was of the mindset that we should keep sending those
> through the QMP tree since most QAPI changes were in support of QMP.
> 
> According to the MAINTAINERS documentation though, M: is meant to be
> "a set of names that developers can consult when they have a question
> about a particular subset and also to provide a set of names to be
> CC'd when submitting a patch to obtain appropriate review.", so if
> that's the case I'd be happy to add my name and help in that regard.

Oh, that's cool. I'll add your name for v2 then.