From: Anthony Liguori <aliguori@us.ibm.com>
To: Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 11/24] console: displaystate init revamp
Date: Wed, 24 Apr 2013 11:38:48 -0500 [thread overview]
Message-ID: <8761zb289z.fsf@codemonkey.ws> (raw)
In-Reply-To: <874nevaomx.fsf@blackfin.pond.sub.org>
Markus Armbruster <armbru@redhat.com> writes:
> Gerd Hoffmann <kraxel@redhat.com> writes:
>
>> We have only one DisplayState, so there is no need for the "next"
>> linking, rip it. Also consolidate all displaystate initialization
>> into init_displaystate(). This function is called by vl.c after
>> creating the devices (and thus all QemuConsoles) and before
>> initializing DisplayChangeListensers (aka gtk/sdl/vnc/spice ui).
>
> Crashes for me on Fedora 17:
>
> $ gdb --args qemu-system-x86_64 -nodefaults -S -vnc :0 -monitor stdio
It's specifically -nodefaults.
qemu-system-x86_64 -vnc :0
Works fine. The following does not:
qemu-system-x86_64 -nodefaults -vnc :0
Regards,
Anthony Liguori
> [...]
> Program received signal SIGSEGV, Segmentation fault.
> 0x00000000006428b9 in surface_height (s=0x0)
> at /home/armbru/work/qemu/include/ui/console.h:253
> 253 return pixman_image_get_height(s->image);
> [...]
> (gdb) bt
> #0 0x00000000006428b9 in surface_height (s=0x0)
> at /home/armbru/work/qemu/include/ui/console.h:253
> #1 0x000000000064434a in vnc_dpy_switch (dcl=0x7fffebbd2050, surface=0x0)
> at /home/armbru/work/qemu/ui/vnc.c:587
> #2 0x000000000061e97d in register_displaychangelistener (ds=0x14dbf30, dcl=
> 0x7fffebbd2050) at /home/armbru/work/qemu/ui/console.c:1188
> #3 0x000000000064a710 in vnc_display_init (ds=0x14dbf30)
> at /home/armbru/work/qemu/ui/vnc.c:2866
> #4 0x000000000065627b in main (argc=8, argv=0x7fffffffe108, envp=
> 0x7fffffffe150) at /home/armbru/work/qemu/vl.c:4370
next prev parent reply other threads:[~2013-04-24 16:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 9:39 [Qemu-devel] [PULL v4 00/24] console: console overhaul continued Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 01/24] exynos4210_fimd.c: fix display resize bug introduced after console revamp Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 02/24] hw/vmware_vga.c: fix screen " Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 03/24] hw/vmware_vga.c: add tracepoints for mmio reads+writes Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 04/24] hw/vmware_vga.c: various vmware vga fixes Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 05/24] pixman: add qemu_pixman_color() Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 06/24] pixman: render vgafont glyphs into pixman images Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 07/24] console: use pixman for fill+blit Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 08/24] console: use pixman for font rendering Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 09/24] console: switch color_table_rgb to pixman_color_t Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 10/24] console: add trace events Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 11/24] console: displaystate init revamp Gerd Hoffmann
2013-04-24 16:18 ` Markus Armbruster
2013-04-24 16:38 ` Anthony Liguori [this message]
2013-04-16 9:39 ` [Qemu-devel] [PATCH 12/24] console: rename vga_hw_*, add QemuConsole param Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 13/24] console: give each QemuConsole its own DisplaySurface Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 14/24] console: simplify screendump Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 15/24] console: zap g_width + g_height Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 16/24] console: move gui_update+gui_setup_refresh from vl.c into console.c Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 17/24] console: make DisplayState private to console.c Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 18/24] console: add GraphicHwOps Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 19/24] console: gui timer fixes Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 20/24] xen: re-enable refresh interval reporting for xenfb Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 21/24] console: add qemu_console_is_* Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 22/24] console: allow pinning displaychangelisteners to consoles Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 23/24] gtk: custom cursor support Gerd Hoffmann
2013-04-16 9:39 ` [Qemu-devel] [PATCH 24/24] qxl: register QemuConsole for secondary cards Gerd Hoffmann
2013-04-17 9:38 ` [Qemu-devel] [PULL v4 00/24] console: console overhaul continued Paolo Bonzini
2013-04-17 11:42 ` Peter Maydell
2013-04-18 6:21 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2013-04-04 7:28 [Qemu-devel] [PATCH v3 " Gerd Hoffmann
2013-04-04 7:28 ` [Qemu-devel] [PATCH 11/24] console: displaystate init revamp Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761zb289z.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).