From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2ir-00035L-Ft for qemu-devel@nongnu.org; Wed, 24 Apr 2013 12:39:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV2io-0003Gb-3F for qemu-devel@nongnu.org; Wed, 24 Apr 2013 12:39:09 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:54305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2in-0003GJ-Hn for qemu-devel@nongnu.org; Wed, 24 Apr 2013 12:39:06 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Apr 2013 02:33:57 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 51A242CE804A for ; Thu, 25 Apr 2013 02:38:56 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3OGPBKQ9109904 for ; Thu, 25 Apr 2013 02:25:12 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r3OGctsN026528 for ; Thu, 25 Apr 2013 02:38:55 +1000 From: Anthony Liguori In-Reply-To: <874nevaomx.fsf@blackfin.pond.sub.org> References: <1366105178-26744-1-git-send-email-kraxel@redhat.com> <1366105178-26744-12-git-send-email-kraxel@redhat.com> <874nevaomx.fsf@blackfin.pond.sub.org> Date: Wed, 24 Apr 2013 11:38:48 -0500 Message-ID: <8761zb289z.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 11/24] console: displaystate init revamp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Gerd Hoffmann Cc: qemu-devel@nongnu.org Markus Armbruster writes: > Gerd Hoffmann writes: > >> We have only one DisplayState, so there is no need for the "next" >> linking, rip it. Also consolidate all displaystate initialization >> into init_displaystate(). This function is called by vl.c after >> creating the devices (and thus all QemuConsoles) and before >> initializing DisplayChangeListensers (aka gtk/sdl/vnc/spice ui). > > Crashes for me on Fedora 17: > > $ gdb --args qemu-system-x86_64 -nodefaults -S -vnc :0 -monitor stdio It's specifically -nodefaults. qemu-system-x86_64 -vnc :0 Works fine. The following does not: qemu-system-x86_64 -nodefaults -vnc :0 Regards, Anthony Liguori > [...] > Program received signal SIGSEGV, Segmentation fault. > 0x00000000006428b9 in surface_height (s=0x0) > at /home/armbru/work/qemu/include/ui/console.h:253 > 253 return pixman_image_get_height(s->image); > [...] > (gdb) bt > #0 0x00000000006428b9 in surface_height (s=0x0) > at /home/armbru/work/qemu/include/ui/console.h:253 > #1 0x000000000064434a in vnc_dpy_switch (dcl=0x7fffebbd2050, surface=0x0) > at /home/armbru/work/qemu/ui/vnc.c:587 > #2 0x000000000061e97d in register_displaychangelistener (ds=0x14dbf30, dcl= > 0x7fffebbd2050) at /home/armbru/work/qemu/ui/console.c:1188 > #3 0x000000000064a710 in vnc_display_init (ds=0x14dbf30) > at /home/armbru/work/qemu/ui/vnc.c:2866 > #4 0x000000000065627b in main (argc=8, argv=0x7fffffffe108, envp= > 0x7fffffffe150) at /home/armbru/work/qemu/vl.c:4370