From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TipWZ-0004C5-Gb for qemu-devel@nongnu.org; Wed, 12 Dec 2012 11:51:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TipWO-0002i3-5Y for qemu-devel@nongnu.org; Wed, 12 Dec 2012 11:51:11 -0500 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:34942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TipWN-0002hD-KB for qemu-devel@nongnu.org; Wed, 12 Dec 2012 11:51:00 -0500 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Dec 2012 02:46:44 +1000 From: "Aneesh Kumar K.V" In-Reply-To: <50C88C2B.2010901@redhat.com> References: <1349868762-10021-1-git-send-email-pbonzini@redhat.com> <50759EEC.8070308@weilnetz.de> <50759F9E.3060800@redhat.com> <5075A0FF.3080904@weilnetz.de> <5075A420.10003@redhat.com> <5075A843.8020107@weilnetz.de> <5075A966.3090708@weilnetz.de> <871uh5tqr7.fsf@explorer.in.ibm.com> <5076BACC.7030309@redhat.com> <87y5hdejes.fsf@linux.vnet.ibm.com> <87obi8ew14.fsf@linux.vnet.ibm.com> <50BF4015.2050102@redhat.com> <50C88C2B.2010901@redhat.com> Date: Wed, 12 Dec 2012 22:20:47 +0530 Message-ID: <8762479pug.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] virtfs-proxy-helper: check return code of setfsgid/setfsuid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-trivial@nongnu.org, Stefan Weil , "M. Mohan Kumar" , qemu-devel@nongnu.org Paolo Bonzini writes: > Il 05/12/2012 13:37, Paolo Bonzini ha scritto: >>> > I have tested the below patch. Currently i don't have a signed-off-by on >>> > the patch. One change noted by mohan which I incorporated in the patch >>> > is we need to call setresgid before calling setresuid. If you are ok >>> > with this change I can send it upstream. >> Yes, please. >> >> Either your version without pointers or mine is okay for me. > > Ping? Merged upstream with commit 9fd2ecdc8cb2dc1a8a7c57b6c9c60bc9947b6a73 -aneesh