From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55687)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TJ07p-0006WT-9i
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:54:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TJ07k-0002Ho-N7
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:54:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52779)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TJ07k-0002HQ-Cs
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:54:48 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q92AslHB006452
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 2 Oct 2012 06:54:47 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <5061986B.3070503@redhat.com> (Orit Wasserman's message of "Tue,
	25 Sep 2012 13:41:31 +0200")
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-18-git-send-email-quintela@redhat.com>
	<5061986B.3070503@redhat.com>
Date: Tue, 02 Oct 2012 12:54:46 +0200
Message-ID: <87626t9ma1.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 17/41] buffered_file: rename opaque to
	migration_state
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Orit Wasserman <owasserm@redhat.com>
Cc: qemu-devel@nongnu.org

Orit Wasserman <owasserm@redhat.com> wrote:
> On 09/21/2012 11:47 AM, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  buffered_file.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>> 
>> diff --git a/buffered_file.c b/buffered_file.c
>> index 7155800..33b700b 100644
>> --- a/buffered_file.c
>> +++ b/buffered_file.c
>> @@ -27,7 +27,7 @@ typedef struct QEMUFileBuffered
>>      BufferedPutReadyFunc *put_ready;
>>      BufferedWaitForUnfreezeFunc *wait_for_unfreeze;
>>      BufferedCloseFunc *close;
>> -    void *opaque;
>> +    void *migration_state;
> Why ?
> This doesn't have to be for migration use only.

Idea is to remove it altogether.  Not useful anymore once that migration
thread is there.

Later, Juan.