From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TA4dg-0004I7-7R for qemu-devel@nongnu.org; Fri, 07 Sep 2012 15:54:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TA4d7-0003z9-S2 for qemu-devel@nongnu.org; Fri, 07 Sep 2012 15:54:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TA4d7-0003z2-JC for qemu-devel@nongnu.org; Fri, 07 Sep 2012 15:54:17 -0400 From: Juan Quintela In-Reply-To: <504A2A1F.8090703@redhat.com> (Paolo Bonzini's message of "Fri, 07 Sep 2012 19:08:47 +0200") References: <87a9x1ls3b.fsf@elfo.mitica> <504A2A1F.8090703@redhat.com> Date: Fri, 07 Sep 2012 21:52:57 +0200 Message-ID: <87627pliee.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC v2] Migration thread Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: chegu_vinod@hp.com, qemu-devel@nongnu.org Paolo Bonzini wrote: > Il 07/09/2012 18:23, Juan Quintela ha scritto: >> >> Hi >> >> here is v2 of the migration thread series. There is still some "issues" >> with locking in the error paths (they are at 54 patches now). >> >> Changes from v1: >> - migration stats series are included >> - migration bitmap sync trace-events to know how long it takes >> - file->last_error use almost removed >> reworked functions to return real error codes and work with that. >> Some more work needed here. >> - new savevm for live migration pending method. see last commit for >> details. > > Can you start factoring out any cleanup that can be applied independently? This is the breakpoint. buffered_file: Move from using a timer to use a thread Everything before this could be integrated Today, from there, it needs still more 'thought". As said, buffered_file.c is almost gone, and file->last_error is almost gone. That were the things that I wanted to clean to be able to split the generation of migration data and its writting. Later, Juan.