From: Juan Quintela <quintela@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile
Date: Tue, 20 Mar 2012 16:49:06 +0100 [thread overview]
Message-ID: <8762dzuvbh.fsf@elfo.elfo> (raw)
In-Reply-To: <4F68A52F.3070003@suse.de> ("Andreas Färber"'s message of "Tue, 20 Mar 2012 16:41:35 +0100")
Andreas Färber <afaerber@suse.de> wrote:
> Am 20.03.2012 16:24, schrieb Juan Quintela:
>> This change makes it compile and return the same value than the #undef one.
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> Cool,
>
> Acked-by: Andreas Färber <afaerber@suse.de>
>
> Tested the default, non-struct version only.
>
> Juan, would it make sense to add a configure option for this #define,
> similar to --enable-debug-tcg?
It depends of its users, clearly it was not used for quite long. Put in
under --enabled-debug? Notice that I have only used this _once_, so I
am not the best person to decide.
Later, Juan.
next prev parent reply other threads:[~2012-03-20 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 15:24 [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile Juan Quintela
2012-03-20 15:36 ` Peter Maydell
2012-03-20 15:41 ` Andreas Färber
2012-03-20 15:49 ` Juan Quintela [this message]
2012-03-20 16:11 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762dzuvbh.fsf@elfo.elfo \
--to=quintela@redhat.com \
--cc=afaerber@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).