From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2808C77B60 for ; Wed, 26 Apr 2023 13:18:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prf2E-0003HR-0V; Wed, 26 Apr 2023 09:18:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prf2C-00030K-8Y for qemu-devel@nongnu.org; Wed, 26 Apr 2023 09:18:12 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prf26-0002A9-9q for qemu-devel@nongnu.org; Wed, 26 Apr 2023 09:18:09 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f1957e80a2so152057755e9.1 for ; Wed, 26 Apr 2023 06:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682515084; x=1685107084; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d+9NRtRRe1F92I0Fp1msG2G1Ckza8Pe6D2HmQb3l4Kk=; b=dCFJ2XLyy+KfMBjIVaWFqd/E8IYymhq0nmtJHXHxVPWINgnZxYFpLyXBGYvaqwuM/m XAM0ToDUiko0ICwM0h1MczqkX/1oTi6ngxHeaFkrss3zQYWKvMfmc/2UKigzfmqTs5cq SnoVaE31GxKAgpoAfhSCxgGrQCRJRU7yJemNP7JJ7lctb4nEixXAs/yoLL2DRejVR9yh RyJV44OC/CaK7e1zAG1owv9PKJukCmbJP0+ct/hvU5AAvIoYeXbpOhULdNgk92GlKerv oQVfoT0jXZCS5LkGxFmXXtlSKzgXHgIsj67BMPZwIMupZUcrDtz4KETrWjwyVl1jef6N QvWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682515084; x=1685107084; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d+9NRtRRe1F92I0Fp1msG2G1Ckza8Pe6D2HmQb3l4Kk=; b=QLGGsJthwR29UyXH/O1ynKWZqXKtaQW5jTQk6AKoR+UZiDhoYYrzbZjYNvvtVDuMmM mCv6rswZWTkIgWgBoGN8cP0FviJib6FoubtVdee+Ah9Rl8SecYcsqX3t8Hm4KZl7sd23 Y55CTF8B0ZgxJa94Uwgh29GhIy0jpY31Edb7j4r9ciNFN5at6s8LymZ+5lGAchVVh+kP LtGw7R70+cxNZ0ICBQY83daJVy7JmS5EazrSO4SNfaqr+blfb8Vj+RvsROa5rmtyIymB pYfk7p7UYOzn0TXMRA0ox9YhqxCtcy5xaTVZgxc/qRsHidCKJhjMVqh1IM5MuQqoIjnA VYCw== X-Gm-Message-State: AC+VfDwLwIREjR4fcYrbV2Evjd+4u7G5VadEGPdn8sMaqHQBrXdaevvI /3iMxnwgt6lt6B+EkKFFPsOOHA== X-Google-Smtp-Source: ACHHUZ6JSWDhYo7QgbpenMv/hFfbFpDsvCPdXHF5nJ3zvFo4FHwdGwx4XdQ5O0s79sCRXaBunAKCKw== X-Received: by 2002:adf:e710:0:b0:2fe:c8b5:b5da with SMTP id c16-20020adfe710000000b002fec8b5b5damr1786537wrm.13.1682515084404; Wed, 26 Apr 2023 06:18:04 -0700 (PDT) Received: from [172.23.2.237] ([31.221.30.162]) by smtp.gmail.com with ESMTPSA id f3-20020adfdb43000000b002efb2d861dasm15865834wrj.77.2023.04.26.06.18.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Apr 2023 06:18:04 -0700 (PDT) Message-ID: <87674a24-5df1-568b-025c-f88cdf5ada9d@linaro.org> Date: Wed, 26 Apr 2023 14:18:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 34/57] tcg: Move TCGLabelQemuLdst to tcg.c Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, git@xen0n.name, jiaxun.yang@flygoat.com References: <20230424054105.1579315-1-richard.henderson@linaro.org> <20230424054105.1579315-35-richard.henderson@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230424054105.1579315-35-richard.henderson@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.422, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 24/4/23 07:40, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 13 +++++++++++++ > tcg/tcg-ldst.c.inc | 14 -------------- > 2 files changed, 13 insertions(+), 14 deletions(-) > > diff --git a/tcg/tcg.c b/tcg/tcg.c > +typedef struct TCGLabelQemuLdst { > + bool is_ld; /* qemu_ld: true, qemu_st: false */ > + MemOpIdx oi; > + TCGType type; /* result type of a load */ > + TCGReg addrlo_reg; /* reg index for low word of guest virtual addr */ > + TCGReg addrhi_reg; /* reg index for high word of guest virtual addr */ > + TCGReg datalo_reg; /* reg index for low word to be loaded or stored */ > + TCGReg datahi_reg; /* reg index for high word to be loaded or stored */ > + const tcg_insn_unit *raddr; /* addr of the next IR of qemu_ld/st IR */ > + tcg_insn_unit *label_ptr[2]; /* label pointers to be updated */ > + QSIMPLEQ_ENTRY(TCGLabelQemuLdst) next; Missing "qemu/queue.h" in header, otherwise: Reviewed-by: Philippe Mathieu-Daudé > +} TCGLabelQemuLdst;=