From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: Xiaojuan Yang <yangxiaojuan@loongson.cn>, laurent@vivier.eu
Subject: Re: [PATCH v11 10/26] target/loongarch: Add floating point arithmetic instruction translation
Date: Sat, 20 Nov 2021 09:54:38 +0100 [thread overview]
Message-ID: <8768ae20-cc6e-5439-e9c0-07917368675a@linaro.org> (raw)
In-Reply-To: <1637302410-24632-11-git-send-email-gaosong@loongson.cn>
On 11/19/21 7:13 AM, Song Gao wrote:
> +static void update_fcsr0_mask(CPULoongArchState *env, uintptr_t pc, int mask)
> +{
> + int flags = get_float_exception_flags(&env->fp_status);
> +
> + set_float_exception_flags(0, &env->fp_status);
> +
> + if (~mask) {
> + flags = flags & (~mask);
> + }
No need for if -- mask will always be valid.
flags &= ~mask.
> + if (!flags) {
> + SET_FP_CAUSE(env->fcsr0, flags);
> + return;
> + }
> +
> + flags = ieee_ex_to_loongarch(flags);
> + SET_FP_CAUSE(env->fcsr0, flags);
It looks like this could be hoisted above the !flags check to unify the two statements.
> +/* Floating-point helper */
> +DEF_HELPER_3(fadd_s, i64, env, i64, i64)
> +DEF_HELPER_3(fadd_d, i64, env, i64, i64)
> +DEF_HELPER_3(fsub_s, i64, env, i64, i64)
> +DEF_HELPER_3(fsub_d, i64, env, i64, i64)
> +DEF_HELPER_3(fmul_s, i64, env, i64, i64)
> +DEF_HELPER_3(fmul_d, i64, env, i64, i64)
> +DEF_HELPER_3(fdiv_s, i64, env, i64, i64)
> +DEF_HELPER_3(fdiv_d, i64, env, i64, i64)
> +DEF_HELPER_3(fmax_s, i64, env, i64, i64)
> +DEF_HELPER_3(fmax_d, i64, env, i64, i64)
> +DEF_HELPER_3(fmin_s, i64, env, i64, i64)
> +DEF_HELPER_3(fmin_d, i64, env, i64, i64)
> +DEF_HELPER_3(fmaxa_s, i64, env, i64, i64)
> +DEF_HELPER_3(fmaxa_d, i64, env, i64, i64)
> +DEF_HELPER_3(fmina_s, i64, env, i64, i64)
> +DEF_HELPER_3(fmina_d, i64, env, i64, i64)
> +
> +DEF_HELPER_5(fmuladd_s, i64, env, i64, i64, i64, i32)
> +DEF_HELPER_5(fmuladd_d, i64, env, i64, i64, i64, i32)
> +
> +DEF_HELPER_3(fscaleb_s, i64, env, i64, i64)
> +DEF_HELPER_3(fscaleb_d, i64, env, i64, i64)
> +
> +DEF_HELPER_2(flogb_s, i64, env, i64)
> +DEF_HELPER_2(flogb_d, i64, env, i64)
> +
> +DEF_HELPER_2(fsqrt_s, i64, env, i64)
> +DEF_HELPER_2(fsqrt_d, i64, env, i64)
> +DEF_HELPER_2(frsqrt_s, i64, env, i64)
> +DEF_HELPER_2(frsqrt_d, i64, env, i64)
> +DEF_HELPER_2(frecip_s, i64, env, i64)
> +DEF_HELPER_2(frecip_d, i64, env, i64)
DEF_HELPER_FLAGS_N, TCG_CALL_NO_WG.
r~
next prev parent reply other threads:[~2021-11-20 8:55 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 6:13 [PATCH v11 00/26] Add LoongArch linux-user emulation support Song Gao
2021-11-19 6:13 ` [PATCH v11 01/26] target/loongarch: Add README Song Gao
2021-11-19 6:13 ` [PATCH v11 02/26] target/loongarch: Add core definition Song Gao
2021-11-19 6:13 ` [PATCH v11 03/26] target/loongarch: Add main translation routines Song Gao
2021-11-19 6:13 ` [PATCH v11 04/26] target/loongarch: Add fixed point arithmetic instruction translation Song Gao
2021-11-20 7:10 ` Richard Henderson
2021-11-20 7:17 ` Richard Henderson
2021-11-20 8:52 ` gaosong
2021-11-20 8:56 ` Richard Henderson
2021-11-22 8:23 ` gaosong
2021-11-22 8:28 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 05/26] target/loongarch: Add fixed point shift " Song Gao
2021-11-20 7:42 ` Richard Henderson
2021-11-20 9:03 ` gaosong
2021-11-19 6:13 ` [PATCH v11 06/26] target/loongarch: Add fixed point bit " Song Gao
2021-11-20 8:05 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 07/26] target/loongarch: Add fixed point load/store " Song Gao
2021-11-20 8:20 ` Richard Henderson
2021-11-20 9:39 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 08/26] target/loongarch: Add fixed point atomic " Song Gao
2021-11-20 8:30 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 09/26] target/loongarch: Add fixed point extra " Song Gao
2021-11-20 8:52 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 10/26] target/loongarch: Add floating point arithmetic " Song Gao
2021-11-20 8:54 ` Richard Henderson [this message]
2021-11-19 6:13 ` [PATCH v11 11/26] target/loongarch: Add floating point comparison " Song Gao
2021-11-20 9:02 ` Richard Henderson
2021-11-30 8:22 ` gaosong
2021-11-30 8:37 ` Richard Henderson
2021-11-30 8:50 ` gaosong
2021-11-19 6:13 ` [PATCH v11 12/26] target/loongarch: Add floating point conversion " Song Gao
2021-11-19 6:13 ` [PATCH v11 13/26] target/loongarch: Add floating point move " Song Gao
2021-11-19 6:13 ` [PATCH v11 14/26] target/loongarch: Add floating point load/store " Song Gao
2021-11-20 9:36 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 15/26] target/loongarch: Add branch " Song Gao
2021-11-20 9:46 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 16/26] target/loongarch: Add disassembler Song Gao
2021-11-20 9:53 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 17/26] linux-user: Add LoongArch generic header files Song Gao
2021-11-20 9:54 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 18/26] linux-user: Add LoongArch specific structures Song Gao
2021-11-20 10:06 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 19/26] linux-user: Add LoongArch signal support Song Gao
2021-11-20 10:33 ` Richard Henderson
2021-11-22 11:41 ` gaosong
2021-11-22 11:44 ` chen huacai
2021-11-22 12:31 ` Richard Henderson
2021-11-24 2:46 ` gaosong
2021-11-24 7:27 ` Richard Henderson
2021-11-24 7:50 ` gaosong
2021-11-24 9:40 ` Richard Henderson
2021-11-24 10:22 ` gaosong
2021-11-24 10:44 ` Richard Henderson
2021-11-25 3:03 ` gaosong
2021-11-25 10:11 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 20/26] linux-user: Add LoongArch elf support Song Gao
2021-11-20 10:35 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 21/26] linux-user: Add LoongArch syscall support Song Gao
2021-11-20 10:47 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 22/26] linux-user: Add LoongArch cpu_loop support Song Gao
2021-11-20 10:53 ` Richard Henderson
2021-11-19 6:13 ` [PATCH v11 23/26] default-configs: Add loongarch linux-user support Song Gao
2021-11-19 6:13 ` [PATCH v11 24/26] target/loongarch: Add target build suport Song Gao
2021-11-19 6:13 ` [PATCH v11 25/26] target/loongarch: 'make check-tcg' support Song Gao
2021-11-19 6:13 ` [PATCH v11 26/26] scripts: add loongarch64 binfmt config Song Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8768ae20-cc6e-5439-e9c0-07917368675a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).