Re: [PULL v2 00/25] Functional tests, Microblaze endianness & pc/q35 cleanups

[Thomas Huth <thuth@redhat.com>]

On 29/05/2025 17.26, Stefan Hajnoczi wrote:
> On Wed, May 28, 2025 at 10:24:42PM +0200, Thomas Huth wrote:
>>   Hi Stefan!
>>
>> The following changes since commit 80db93b2b88f9b3ed8927ae7ac74ca30e643a83e:
>>
>>    Merge tag 'pull-aspeed-20250526' of https://github.com/legoater/qemu into staging (2025-05-26 10:16:59 -0400)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/thuth/qemu.git tags/pull-request-2025-05-28v2
>>
>> for you to fetch changes up to 51c214b7c27096e3516aedf6befd69dc6d75b4ac:
>>
>>    tests/unit/test-util-sockets: fix mem-leak on error object (2025-05-28 22:16:26 +0200)
>>
>> ----------------------------------------------------------------
>> * Functional tests improvements
>> * Endianness improvements/clean-ups for the Microblaze machines
>> * Remove obsolete -2.4 and -2.5 i440fx and q35 machine types and related code
>>
>> v2: Dropped the memlock test patches
> 
> Please take a look at the following CI failure:
> 
> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 QTEST_QEMU_BINARY=./qemu-system-microblaze QTEST_QEMU_IMG=./qemu-img UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 G_TEST_DBUS_DAEMON=/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/tests/dbus-vmstate-daemon.sh MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 RUST_BACKTRACE=1 QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon PYTHON=/home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/build/pyvenv/bin/python3 MALLOC_PERTURB_=57 MESON_TEST_ITERATION=1 /home/gitlab-runner/builds/E8PpwMky/0/qemu-project/qemu/build/tests/qtest/test-netfilter --tap -k
> ――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――
> stderr:
> munmap_chunk(): invalid pointer
> ../tests/qtest/libqtest.c:208: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped)
> (test program exited with status code -6)
> 
> More info here:
> https://gitlab.com/qemu-project/qemu/-/jobs/10190886460#L5038

Drat, I think I missed:

diff --git a/hw/microblaze/petalogix_s3adsp1800_mmu.c 
b/hw/microblaze/petalogix_s3adsp1800_mmu.c
--- a/hw/microblaze/petalogix_s3adsp1800_mmu.c
+++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c
@@ -187,6 +187,7 @@ static const TypeInfo 
petalogix_s3adsp1800_machine_types[] = {
          .name           = TYPE_PETALOGIX_S3ADSP1800_MACHINE,
          .parent         = TYPE_MACHINE,
          .class_init     = petalogix_s3adsp1800_machine_class_init,
+        .instance_size  = sizeof(S3Adsp1800MachineState),
      },
  };

... I'll respin the PR with that fix included.

  Thomas