Re: [PATCH] scripts/device-crash-test: ERROR_RULE_LIST garbage collection

[Markus Armbruster <armbru@redhat.com>]

Thomas Huth <thuth@redhat.com> writes:

> On 27/11/2025 15.49, Markus Armbruster wrote:
>> Device 'nand' was dropped in commit commit e86c1f967a3.
>> Device 'vfio-amd-xgbe' was dropped in commit aeb1a50d4a7.
>> Device 'vfio-calxeda-xgmac' was dropped in commit 8ebc416ac17.
>> The last error messages matching r"images* must be given with the
>> 'pflash' parameter" was dropped in commit a2ccff4d2bc.
>> The error message matching r"Option '-device [\w.,-]+' cannot be
>> handled by this machine" was dropped in commit commit db78a605599.
>> As far as I can tell, we never had message matching r"Ignoring
>> smp_cpus value"
>
> This was a wrapped string, it has been changed in comnit f2ad5140fa521bda30b9c3c3db5b6913f6dda1ae ("hw/arm/exynos: Convert fprintf to qemu_log_mask/error_report") and finally been removed in commit
> 7264961934130df50d151def5eb415efa2e28ec5.
>
>> or r"MSI-X support is mandatory in the S390
>> architecture".
>
> This (split) string still exists in hw/s390x/s390-pci-bus.c:
>
> $ grep -r -A1 MSI-X.support.is.mandatory hw/
> hw/s390x/s390-pci-bus.c:            error_setg(errp, "MSI-X support is mandatory "
> hw/s390x/s390-pci-bus.c-                       "in the S390 architecture");

Watch me fail at grepping.

> So I think we should keep it.

Yes.

v2 coming.  Thanks!