* [PATCH] tests/functional/test_aarch64_rme_virt: fix sporadic failure
@ 2025-03-28 18:38 Pierrick Bouvier
2025-03-28 19:09 ` Richard Henderson
2025-03-28 20:05 ` Alex Bennée
0 siblings, 2 replies; 3+ messages in thread
From: Pierrick Bouvier @ 2025-03-28 18:38 UTC (permalink / raw)
To: qemu-devel
Cc: richard.henderson, berrange, peter.maydell, alex.bennee, qemu-arm,
thuth, Pierrick Bouvier
This test was randomly failing on our CI, and on dev machines,
especially with QEMU debug builds.
From the information collected, it's related to an implementation choice
in edk2 QEMU virt support. The workaround is to disable KASLR, to avoid
accessing protected memory.
Note: this is *not* needed for the similar test_aarch64_rme_sbsaref.
More information is available on the associated GitLab issue.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2823
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
tests/functional/test_aarch64_rme_virt.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/functional/test_aarch64_rme_virt.py b/tests/functional/test_aarch64_rme_virt.py
index f4ad4d33d58..a1abf584f0e 100755
--- a/tests/functional/test_aarch64_rme_virt.py
+++ b/tests/functional/test_aarch64_rme_virt.py
@@ -87,7 +87,9 @@ def test_aarch64_rme_virt(self):
self.vm.add_args('-fsdev', f'local,security_model=none,path={rme_stack},id=shr0')
self.vm.add_args('-device', 'virtio-net-pci,netdev=net0')
self.vm.add_args('-netdev', 'user,id=net0')
- self.vm.add_args('-append', 'root=/dev/vda')
+ # We need to add nokaslr to avoid triggering this sporadic bug:
+ # https://gitlab.com/qemu-project/qemu/-/issues/2823
+ self.vm.add_args('-append', 'root=/dev/vda nokaslr')
self.vm.launch()
# Wait for host VM boot to complete.
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/functional/test_aarch64_rme_virt: fix sporadic failure
2025-03-28 18:38 [PATCH] tests/functional/test_aarch64_rme_virt: fix sporadic failure Pierrick Bouvier
@ 2025-03-28 19:09 ` Richard Henderson
2025-03-28 20:05 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2025-03-28 19:09 UTC (permalink / raw)
To: Pierrick Bouvier, qemu-devel
Cc: berrange, peter.maydell, alex.bennee, qemu-arm, thuth
On 3/28/25 13:38, Pierrick Bouvier wrote:
> This test was randomly failing on our CI, and on dev machines,
> especially with QEMU debug builds.
>
> From the information collected, it's related to an implementation choice
> in edk2 QEMU virt support. The workaround is to disable KASLR, to avoid
> accessing protected memory.
> Note: this is *not* needed for the similar test_aarch64_rme_sbsaref.
>
> More information is available on the associated GitLab issue.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2823
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> tests/functional/test_aarch64_rme_virt.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/functional/test_aarch64_rme_virt.py b/tests/functional/test_aarch64_rme_virt.py
> index f4ad4d33d58..a1abf584f0e 100755
> --- a/tests/functional/test_aarch64_rme_virt.py
> +++ b/tests/functional/test_aarch64_rme_virt.py
> @@ -87,7 +87,9 @@ def test_aarch64_rme_virt(self):
> self.vm.add_args('-fsdev', f'local,security_model=none,path={rme_stack},id=shr0')
> self.vm.add_args('-device', 'virtio-net-pci,netdev=net0')
> self.vm.add_args('-netdev', 'user,id=net0')
> - self.vm.add_args('-append', 'root=/dev/vda')
> + # We need to add nokaslr to avoid triggering this sporadic bug:
> + # https://gitlab.com/qemu-project/qemu/-/issues/2823
> + self.vm.add_args('-append', 'root=/dev/vda nokaslr')
>
> self.vm.launch()
> # Wait for host VM boot to complete.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/functional/test_aarch64_rme_virt: fix sporadic failure
2025-03-28 18:38 [PATCH] tests/functional/test_aarch64_rme_virt: fix sporadic failure Pierrick Bouvier
2025-03-28 19:09 ` Richard Henderson
@ 2025-03-28 20:05 ` Alex Bennée
1 sibling, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2025-03-28 20:05 UTC (permalink / raw)
To: Pierrick Bouvier
Cc: qemu-devel, richard.henderson, berrange, peter.maydell, qemu-arm,
thuth
Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
> This test was randomly failing on our CI, and on dev machines,
> especially with QEMU debug builds.
>
> From the information collected, it's related to an implementation choice
> in edk2 QEMU virt support. The workaround is to disable KASLR, to avoid
> accessing protected memory.
> Note: this is *not* needed for the similar test_aarch64_rme_sbsaref.
>
> More information is available on the associated GitLab issue.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2823
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/functional/test_aarch64_rme_virt.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/functional/test_aarch64_rme_virt.py b/tests/functional/test_aarch64_rme_virt.py
> index f4ad4d33d58..a1abf584f0e 100755
> --- a/tests/functional/test_aarch64_rme_virt.py
> +++ b/tests/functional/test_aarch64_rme_virt.py
> @@ -87,7 +87,9 @@ def test_aarch64_rme_virt(self):
> self.vm.add_args('-fsdev', f'local,security_model=none,path={rme_stack},id=shr0')
> self.vm.add_args('-device', 'virtio-net-pci,netdev=net0')
> self.vm.add_args('-netdev', 'user,id=net0')
> - self.vm.add_args('-append', 'root=/dev/vda')
> + # We need to add nokaslr to avoid triggering this sporadic bug:
> + # https://gitlab.com/qemu-project/qemu/-/issues/2823
> + self.vm.add_args('-append', 'root=/dev/vda nokaslr')
>
> self.vm.launch()
> # Wait for host VM boot to complete.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-28 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-28 18:38 [PATCH] tests/functional/test_aarch64_rme_virt: fix sporadic failure Pierrick Bouvier
2025-03-28 19:09 ` Richard Henderson
2025-03-28 20:05 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).