qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Cc: qemu-devel@nongnu.org,  Alexandre Iooss <erdnaxe@crans.org>,
	 Cleber Rosa <crosa@redhat.com>,
	 Mahmoud Mandour <ma.mandourr@gmail.com>,
	 John Snow <jsnow@redhat.com>
Subject: Re: [PATCH v3 0/3] plugins: generate list of symbols automatically
Date: Tue, 12 Nov 2024 21:08:39 +0000	[thread overview]
Message-ID: <877c98upm0.fsf@draig.linaro.org> (raw)
In-Reply-To: <20241106170923.2976750-1-pierrick.bouvier@linaro.org> (Pierrick Bouvier's message of "Wed, 6 Nov 2024 09:09:20 -0800")

Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:

> Now that meson build for plugins was merged, we can cleanup another part with
> the symbols file.
> It has to be kept in sync between the header (qemu-plugin.h) and the symbols
> file. This has proved to be error prone and tedious.
>
> We solve this by generating this list from header directly using a python
> script. Dependencies are triggered correctly, and the file is regenerated if the
> header is modified, as expected.
>
> Pierrick Bouvier (3):
>   plugins: add missing export for qemu_plugin_num_vcpus
>   plugins: detect qemu plugin API symbols from header
>   plugins: eradicate qemu-plugins.symbols static file
>
>  MAINTAINERS                    |  1 +
>  include/qemu/qemu-plugin.h     |  1 +
>  plugins/meson.build            | 12 +++++--

this failed to apply cleanly. 

>  plugins/qemu-plugins.symbols   | 59 ----------------------------------
>  scripts/qemu-plugin-symbols.py | 45 ++++++++++++++++++++++++++
>  5 files changed, 56 insertions(+), 62 deletions(-)
>  delete mode 100644 plugins/qemu-plugins.symbols
>  create mode 100755 scripts/qemu-plugin-symbols.py

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  parent reply	other threads:[~2024-11-12 21:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06 17:09 [PATCH v3 0/3] plugins: generate list of symbols automatically Pierrick Bouvier
2024-11-06 17:09 ` [PATCH v3 1/3] plugins: add missing export for qemu_plugin_num_vcpus Pierrick Bouvier
2024-11-06 17:37   ` Pierrick Bouvier
2024-11-06 17:09 ` [PATCH v3 2/3] plugins: detect qemu plugin API symbols from header Pierrick Bouvier
2024-11-06 17:09 ` [PATCH v3 3/3] plugins: eradicate qemu-plugins.symbols static file Pierrick Bouvier
2024-11-12 21:08 ` Alex Bennée [this message]
2024-11-12 21:27   ` [PATCH v3 0/3] plugins: generate list of symbols automatically Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877c98upm0.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=erdnaxe@crans.org \
    --cc=jsnow@redhat.com \
    --cc=ma.mandourr@gmail.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).