From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28BCAE7E636 for ; Tue, 26 Sep 2023 13:16:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ql7uq-0005Yq-0v; Tue, 26 Sep 2023 09:15:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql7un-0005YQ-VS for qemu-devel@nongnu.org; Tue, 26 Sep 2023 09:15:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql7um-0008U3-5C for qemu-devel@nongnu.org; Tue, 26 Sep 2023 09:15:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695734146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OhbQdD8u6hqNreuypAlgWRXLqS1rVJEsDccvcyZoBPo=; b=L3xa/EIqmruR9Q1Vru6wEL6sSNTR8f53QGJXA+Npz807oFrR+544TO9d9iVlO+2lxgj6Ay DCmlKyhSRJahPA89q1FjBG37bQUNZxpJ/fQ7Iazw6KhUrWQYfTLrackfaS0kXo8sqCAAUq cwGo9SmU17jveorpjSAvkxi4nuj8ruA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-616-Ps7sby1NMcqZwpTijWYrlA-1; Tue, 26 Sep 2023 09:15:43 -0400 X-MC-Unique: Ps7sby1NMcqZwpTijWYrlA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A32B7811E7E; Tue, 26 Sep 2023 13:15:42 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80E0428FD; Tue, 26 Sep 2023 13:15:42 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 718C421E6900; Tue, 26 Sep 2023 15:15:41 +0200 (CEST) From: Markus Armbruster To: Thomas Huth Cc: Laurent Vivier , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH] m68k: Silence -Wshadow=local warnings in the m68k code References: <20230925185603.106945-1-thuth@redhat.com> <87jzsd3z5q.fsf@pond.sub.org> Date: Tue, 26 Sep 2023 15:15:41 +0200 In-Reply-To: (Thomas Huth's message of "Tue, 26 Sep 2023 14:59:18 +0200") Message-ID: <877codqdmq.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Thomas Huth writes: > On 26/09/2023 14.19, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> Rename the innermost variables to make the code compile >>> without warnings when using -Wshadow=local. >>> >>> Signed-off-by: Thomas Huth >> >> Clashes with patches from Philippe and Laurent: >> >> [PATCH v2 05/22] target/m68k: Clean up local variable shadowing >> [PATCH] disas/m68k: clean up local variable shadowing >> >> You guys figure out how to combine them, please :) > > Ok, then never mind about my patch. > Anyway, it's getting confusing what has already been fixed and what not ... could you please pick up all patches that are available so far and send a pull request for them? I'm collecting at https://repo.or.cz/qemu/armbru.git in branch shadow-next. I'll send a new summary shortly. I intend to send a PR, but first I need to collect R-bys and drop patches that aren't ready, if any.