From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 286F1CE7A94 for ; Mon, 25 Sep 2023 11:06:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkjPO-0006dS-Js; Mon, 25 Sep 2023 07:05:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkjPM-0006bs-8z for qemu-devel@nongnu.org; Mon, 25 Sep 2023 07:05:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkjPK-0003VX-Cz for qemu-devel@nongnu.org; Mon, 25 Sep 2023 07:05:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695639941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tSiXhg7O6fxSFsDaE+jTLIFbtfmyKZG1tiIh/KHykFc=; b=FDE/RZt1v60PI0n2w22YsPjWN2yp97+x+ayj1An5TIOUaJ3+kiXiuOQP08j+Nwwxk1Bf50 LJcvNZ+PIAtIsU3/FnJS1nVsqgaPMDbrd+mC81dRjqjXgMD6PhmT8EXUTGZYbBQPhQwkJw 3kRSsKpvrRg6/UQ7E6oxs/u2pnDK+Fo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-576-KRqn2h0aO22BKQkZTTMpRg-1; Mon, 25 Sep 2023 07:05:37 -0400 X-MC-Unique: KRqn2h0aO22BKQkZTTMpRg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C598A29A9D4F; Mon, 25 Sep 2023 11:05:36 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A28A140C2064; Mon, 25 Sep 2023 11:05:36 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A02EB21E6900; Mon, 25 Sep 2023 13:05:35 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Eduardo Habkost Subject: Re: [PATCH v2 00/15] hw: Use QOM alias properties and few QOM/QDev cleanups References: <20230203145536.17585-1-philmd@linaro.org> <06ed6fa4-1891-998c-f962-bf5a635c23fd@linaro.org> Date: Mon, 25 Sep 2023 13:05:35 +0200 In-Reply-To: <06ed6fa4-1891-998c-f962-bf5a635c23fd@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Tue, 19 Sep 2023 14:35:34 +0200") Message-ID: <877coe8qdc.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > On 3/2/23 15:55, Philippe Mathieu-Daud=C3=A9 wrote: >> Since v1: >> - Addressed Markus & Zoltan review comments >> - Introduce/use qdev_unrealize_and_unref() >> These patches are extracted from a QOM/QDev refactor series, >> so they are preliminary cleanups noticed while working on it: >> - Use correct type when calling qdev_prop_set_xxx() >> - Unify some qdev properties in MIPS models >> - Replace intermediate properties by link properties >> - Remove DEFINE_PROP_DMAADDR() macro which is used one time >> - Use qdev_realize_and_unref() instead of open-coding it >> Philippe Mathieu-Daud=C3=A9 (15): >> hw/pci/pcie_sriov: Replace fprintf(error_pretty) -> >> warn_reportf_err() >> hw/qdev: Introduce qdev_unrealize_and_unref() >> linux-user/syscall: Do not open-code qdev_unrealize_and_unref() >> hw/pci/pcie_sriov: Do not open-code qdev_unrealize_and_unref() >> hw/i386/sgx: Do not open-code qdev_realize_and_unref() >> hw/ppc/sam460ex: Correctly set MAL properties >> hw/arm/nrf51: Alias 'flash-size' QOM property in SoC object >> hw/arm/fsl-imx: Alias 'phy-num' QOM property in SoC object >> hw/usb/hcd-ohci: Include missing 'sysbus.h' header >> hw/display/sm501: Embed OHCI QOM child in chipset >> hw/display/sm501: Alias 'dma-offset' QOM property in chipset object >> hw/display/sm501: Unify common QOM properties >> hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h' >> hw/mips: Declare all length properties as unsigned >> hw/mips/itu: Pass SAAR using QOM link property > > Ping for review? Needs a rebase. I reviewed some all the same. If you want more from me before you respin, let me know.