From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5248DEDEC50 for ; Wed, 13 Sep 2023 13:33:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgPzB-0007cB-ND; Wed, 13 Sep 2023 09:32:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgPz4-0007X4-1n for qemu-devel@nongnu.org; Wed, 13 Sep 2023 09:32:46 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgPz1-00015D-Sj for qemu-devel@nongnu.org; Wed, 13 Sep 2023 09:32:45 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AFA90215EF; Wed, 13 Sep 2023 13:32:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694611961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5rGioZu/kKX+UnHyRLDjF9LHBbxCG7t4xBh8HJLACeY=; b=TVcUhPcT93agOazKKvRuEIngasOWpLGlFFLVuXIddpXeuCLX7PhPbZEH9k0TGloHaME4kJ smxBMqutIf5QQoGt/5ln0GuIsFFkghzh3Nr5oPDnQoKprkDfAVakW59Icx4vbh6pXlyglN VeNS7aYYJ3U+Ru1Qw2nsfW5+zaZPdnk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694611961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5rGioZu/kKX+UnHyRLDjF9LHBbxCG7t4xBh8HJLACeY=; b=tsQaus6+xiXSydhxdhYpMtkyNy1kMv4MSpQap9KsaFTjZB/PQjlByQu94UrU8mYlz7m1yE AJxuAWcuNKUVCnBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2CD1313582; Wed, 13 Sep 2023 13:32:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id m+MYN/i5AWXfRwAAMHmgww (envelope-from ); Wed, 13 Sep 2023 13:32:40 +0000 From: Fabiano Rosas To: Peter Xu , qemu-devel@nongnu.org Cc: peterx@redhat.com, Juan Quintela Subject: Re: [PATCH v2 02/11] migration: Let migrate_set_error() take ownership In-Reply-To: <20230912222145.731099-3-peterx@redhat.com> References: <20230912222145.731099-1-peterx@redhat.com> <20230912222145.731099-3-peterx@redhat.com> Date: Wed, 13 Sep 2023 10:32:38 -0300 Message-ID: <877coukxl5.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Peter Xu writes: > migrate_set_error() used one error_copy() so it always copy an error. > However that's not the major use case - the major use case is one would > like to pass the error to migrate_set_error() without further touching the > error. > > It can be proved if we see most of the callers are freeing the error > explicitly right afterwards. There're a few outliers (only if when the > caller) where we can use error_copy() explicitly there. > > Drop three call sites where we called migrate_set_error() then following a > error_report_err(): otherwise we need to do error_copy() for them. Since we > already have them stored in MigrationState.error, the error report can be > slightly duplicated. > > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas