From: Marian Postevca <posteuca@mutex.one>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Sergio Lopez <slp@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Dongjiu Geng <gengdongjiu@huawei.com>,
Shannon Zhao <shannon.zhaosl@gmail.com>,
Xiang Zheng <zhengxiang9@huawei.com>,
"open list:ACPI/HEST/GHES" <qemu-arm@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields
Date: Mon, 15 Feb 2021 20:26:10 +0200 [thread overview]
Message-ID: <877dn9w5kt.fsf@mutex.one> (raw)
In-Reply-To: <20210215184404.7e342872@redhat.com>
Igor Mammedov <imammedo@redhat.com> writes:
> hmm, looks like adding instead of removing
>
Do you mean that the commit message does not describe the change
correctly, or that my refactoring is too extreme?
If it is the latter, I think I tried to simplify things, by creating
macros to be used in multiple places where this structure is created.
And passing the structure around instead of two parameters seemed simpler.
> have you considered, putting this field into X86MachineState?
> (that way you will be able to handle both PC and microvm in one place,
> without duplication io init/property setters)
>
I did not, will try this approach.
next prev parent reply other threads:[~2021-02-15 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 10:22 [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields Marian Postevca
2021-02-15 17:44 ` Igor Mammedov
2021-02-15 18:26 ` Marian Postevca [this message]
2021-02-16 22:11 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dn9w5kt.fsf@mutex.one \
--to=posteuca@mutex.one \
--cc=ehabkost@redhat.com \
--cc=gengdongjiu@huawei.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shannon.zhaosl@gmail.com \
--cc=slp@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).