From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68205C433DB for ; Mon, 8 Feb 2021 19:25:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6AC464DC3 for ; Mon, 8 Feb 2021 19:25:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6AC464DC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9CAG-0003oP-Oq for qemu-devel@archiver.kernel.org; Mon, 08 Feb 2021 14:25:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l97eo-0003xn-Ie for qemu-devel@nongnu.org; Mon, 08 Feb 2021 09:36:56 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:35146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l97eZ-0003CQ-0l for qemu-devel@nongnu.org; Mon, 08 Feb 2021 09:36:50 -0500 Received: by mail-wr1-x42f.google.com with SMTP id l12so17438909wry.2 for ; Mon, 08 Feb 2021 06:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=5egha2QnD0RR2IdHbFZ0Il093WPbovj4c3xLJqCEJLo=; b=c9RbL2kHECbnf0oxnzxEIhYCY6OyKuhya1k336NCTbhB0qNfXyqUjWX/db7NkR1wy7 Upi7DcQc4RlDA8cLyTEieEvSlHvQzRwOJSdz6GUDJgStTJ3GIwK0clnrJNzeOokVkXzg I5WzzUi6F8V4Rw/GRrRA54Mg4aL6dL3aRNzzmqrXIBtbLkkXfHJ29cqVZ4qoUcA47zwi x0ydZqg+Bp41C+JjnrR2GAw2K0W9JJZj6dsvtf8Js9U3zdfhjSw0QOldW0Z/0lLMhbfC AfTNcaq/uxCpyLxFMOPANbs8SIcAGh9U+h0eLvPk7RPnxupvP58ziKZWl93VieN65H4Y ElJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=5egha2QnD0RR2IdHbFZ0Il093WPbovj4c3xLJqCEJLo=; b=JzXzhh1LaR79GEiYsOFgIrJ5tDlwx9M1EC+NIkPYKGJ6EX4ZFnbG60DukWI3kauoxc Gv/FTxtfCOprrcClGxYSKvCAhO5QguiWnnee8HpQsOWcCoIlRbcYsBtGThpShi3JDJVf KWQUuJ+jogKHjhudxRnFQbHroMoNaSjXoNMYeIlIz6peEgZn4jpjqmbtY47DwVV/Qcw1 GMLpgkb7QXcPIHP/AjHLrKh1KL3vOD4onZ30nTPhSVVlgZ1OUp7d0FCy4hLfdVkHYVC8 pvHDd5wZRpozvrWPKk4fWd5t1zTHEzKYBUMif1zDOr6+I6G75v2CnvQMU1LsCsWSlpNV yV/A== X-Gm-Message-State: AOAM533ptEt6uSddvoYwJnfzjtuYgL0sec9XpSHN8Op4MnuyAnSexsiW JrB8grUSknMm2oBXSP4VjL9GGQ== X-Google-Smtp-Source: ABdhPJyY9Il6EtsRtM0PvNLcnHq68dIii3hbQO7lWzOnSm1JT2tR/pCBQblS9FTlG1A+7L7YXXIYJw== X-Received: by 2002:a5d:464f:: with SMTP id j15mr12759184wrs.390.1612794987704; Mon, 08 Feb 2021 06:36:27 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a21sm17470627wmb.5.2021.02.08.06.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 06:36:26 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A2E0A1FF7E; Mon, 8 Feb 2021 14:36:25 +0000 (GMT) References: <20210207232310.2505283-1-f4bug@amsat.org> <20210207232310.2505283-5-f4bug@amsat.org> User-agent: mu4e 1.5.7; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2 4/6] accel/tcg: Include missing "tcg/tcg.h" header Date: Mon, 08 Feb 2021 14:36:04 +0000 In-reply-to: <20210207232310.2505283-5-f4bug@amsat.org> Message-ID: <877dnibp92.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , qemu-riscv@nongnu.org, Yoshinori Sato , Sagar Karandikar , Bastian Koppelmann , Richard Henderson , qemu-devel@nongnu.org, Laurent Vivier , qemu-arm@nongnu.org, Alistair Francis , Claudio Fontana , Paolo Bonzini , Palmer Dabbelt , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > Commit 3468b59e18b ("tcg: enable multiple TCG contexts in softmmu") > introduced use of typedef/prototypes declared in "tcg/tcg.h" without > including it. This was not a problem because "tcg/tcg.h" is pulled > in by "exec/cpu_ldst.h". To be able to remove this header there, we > first need to include it here in op_helper.c, else we get: > > accel/tcg/tcg-accel-ops-mttcg.c: In function =E2=80=98mttcg_cpu_thread_= fn=E2=80=99: > accel/tcg/tcg-accel-ops-mttcg.c:52:5: error: implicit declaration of fu= nction =E2=80=98tcg_register_thread=E2=80=99; did you mean =E2=80=98rcu_reg= ister_thread=E2=80=99? [-Werror=3Dimplicit-function-declaration] > 52 | tcg_register_thread(); > | ^~~~~~~~~~~~~~~~~~~ > | rcu_register_thread > accel/tcg/tcg-accel-ops-mttcg.c:52:5: error: nested extern declaration = of =E2=80=98tcg_register_thread=E2=80=99 [-Werror=3Dnested-externs] > cc1: all warnings being treated as errors > > accel/tcg/tcg-accel-ops-rr.c: In function =E2=80=98rr_cpu_thread_fn=E2= =80=99: > accel/tcg/tcg-accel-ops-rr.c:153:5: error: implicit declaration of func= tion =E2=80=98tcg_register_thread=E2=80=99; did you mean =E2=80=98rcu_regis= ter_thread=E2=80=99? [-Werror=3Dimplicit-function-declaration] > 153 | tcg_register_thread(); > | ^~~~~~~~~~~~~~~~~~~ > | rcu_register_thread > accel/tcg/tcg-accel-ops-rr.c:153:5: error: nested extern declaration of= =E2=80=98tcg_register_thread=E2=80=99 [-Werror=3Dnested-externs] > cc1: all warnings being treated as errors > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > accel/tcg/tcg-accel-ops-mttcg.c | 1 + > accel/tcg/tcg-accel-ops-rr.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mt= tcg.c > index 42973fb062b..ddbca6c5b8c 100644 > --- a/accel/tcg/tcg-accel-ops-mttcg.c > +++ b/accel/tcg/tcg-accel-ops-mttcg.c > @@ -32,6 +32,7 @@ > #include "exec/exec-all.h" > #include "hw/boards.h" >=20=20 > +#include "tcg/tcg.h" > #include "tcg-accel-ops.h" > #include "tcg-accel-ops-mttcg.h" >=20=20 > diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c > index 4a66055e0d7..1bb1d0f8f1c 100644 > --- a/accel/tcg/tcg-accel-ops-rr.c > +++ b/accel/tcg/tcg-accel-ops-rr.c > @@ -32,6 +32,7 @@ > #include "exec/exec-all.h" > #include "hw/boards.h" >=20=20 > +#include "tcg/tcg.h" > #include "tcg-accel-ops.h" > #include "tcg-accel-ops-rr.h" > #include "tcg-accel-ops-icount.h" Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e