* [PATCH] .travis.yml: reduce scope of the --enable-debug build
@ 2019-10-07 16:07 Alex Bennée
2019-10-07 16:25 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Alex Bennée @ 2019-10-07 16:07 UTC (permalink / raw)
To: qemu-devel; +Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée
Adding debug makes things run a bit slower so lets not hammer all the
targets.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
.travis.yml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index d0b9e099b9..fc0888aff5 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -124,12 +124,13 @@ matrix:
- CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
+ # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
- env:
- - CONFIG="--enable-debug --enable-debug-tcg --disable-user"
+ - CONFIG="--enable-debug --enable-debug-tcg --target-list=${MAIN_SOFTMMU_TARGETS}"
- CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
- # TCG debug can be run just on it's own and is mostly agnostic to user/softmmu distinctions
+ # TCG debug can be run just on its own and is mostly agnostic to user/softmmu distinctions
- env:
- CONFIG="--enable-debug-tcg --disable-system"
- CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build
2019-10-07 16:07 [PATCH] .travis.yml: reduce scope of the --enable-debug build Alex Bennée
@ 2019-10-07 16:25 ` Peter Maydell
2019-10-07 19:05 ` Alex Bennée
0 siblings, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2019-10-07 16:25 UTC (permalink / raw)
To: Alex Bennée; +Cc: Fam Zheng, Philippe Mathieu-Daudé, QEMU Developers
On Mon, 7 Oct 2019 at 17:22, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Adding debug makes things run a bit slower so lets not hammer all the
> targets.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .travis.yml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index d0b9e099b9..fc0888aff5 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -124,12 +124,13 @@ matrix:
> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>
>
> + # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
> - env:
> - - CONFIG="--enable-debug --enable-debug-tcg --disable-user"
> + - CONFIG="--enable-debug --enable-debug-tcg --target-list=${MAIN_SOFTMMU_TARGETS}"
> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
If (as noted in the comment) --enable-debug implies
--enable-debug-tcg, why do we need to give both options ?
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build
2019-10-07 16:25 ` Peter Maydell
@ 2019-10-07 19:05 ` Alex Bennée
2019-10-07 19:08 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: Alex Bennée @ 2019-10-07 19:05 UTC (permalink / raw)
To: Peter Maydell; +Cc: Fam Zheng, Philippe Mathieu-Daudé, QEMU Developers
Peter Maydell <peter.maydell@linaro.org> writes:
> On Mon, 7 Oct 2019 at 17:22, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Adding debug makes things run a bit slower so lets not hammer all the
>> targets.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> .travis.yml | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index d0b9e099b9..fc0888aff5 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -124,12 +124,13 @@ matrix:
>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>
>>
>> + # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
>> - env:
>> - - CONFIG="--enable-debug --enable-debug-tcg --disable-user"
>> + - CONFIG="--enable-debug --enable-debug-tcg --target-list=${MAIN_SOFTMMU_TARGETS}"
>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
>
> If (as noted in the comment) --enable-debug implies
> --enable-debug-tcg, why do we need to give both options ?
We don't really - I was just being verbose. I'll drop it.
>
> thanks
> -- PMM
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] .travis.yml: reduce scope of the --enable-debug build
2019-10-07 19:05 ` Alex Bennée
@ 2019-10-07 19:08 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-07 19:08 UTC (permalink / raw)
To: Alex Bennée, Peter Maydell; +Cc: Fam Zheng, QEMU Developers
On 10/7/19 9:05 PM, Alex Bennée wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> On Mon, 7 Oct 2019 at 17:22, Alex Bennée <alex.bennee@linaro.org> wrote:
>>>
>>> Adding debug makes things run a bit slower so lets not hammer all the
>>> targets.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>> .travis.yml | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/.travis.yml b/.travis.yml
>>> index d0b9e099b9..fc0888aff5 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -124,12 +124,13 @@ matrix:
>>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
>>>
>>>
>>> + # --enable-debug implies --enable-debug-tcg, also runs quite a bit slower
>>> - env:
>>> - - CONFIG="--enable-debug --enable-debug-tcg --disable-user"
>>> + - CONFIG="--enable-debug --enable-debug-tcg --target-list=${MAIN_SOFTMMU_TARGETS}"
>>> - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
>>
>> If (as noted in the comment) --enable-debug implies
>> --enable-debug-tcg, why do we need to give both options ?
>
> We don't really - I was just being verbose. I'll drop it.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-07 19:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-07 16:07 [PATCH] .travis.yml: reduce scope of the --enable-debug build Alex Bennée
2019-10-07 16:25 ` Peter Maydell
2019-10-07 19:05 ` Alex Bennée
2019-10-07 19:08 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).