qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Emilio G. Cota" <cota@braap.org>
Cc: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v5 1/6] target/alpha: remove tlb_flush from alpha_cpu_initfn
Date: Tue, 09 Oct 2018 19:14:10 +0100	[thread overview]
Message-ID: <877eirm1hp.fsf@linaro.org> (raw)
In-Reply-To: <20181009174557.16125-2-cota@braap.org>


Emilio G. Cota <cota@braap.org> writes:

> As far as I can tell tlb_flush does not need to be called
> this early. tlb_flush is eventually called after the CPU
> has been realized.
>
> This change paves the way to the introduction of tlb_init,
> which will be called from cpu_exec_realizefn.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  target/alpha/cpu.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c
> index b08078e7fc..a953897fcc 100644
> --- a/target/alpha/cpu.c
> +++ b/target/alpha/cpu.c
> @@ -201,7 +201,6 @@ static void alpha_cpu_initfn(Object *obj)
>      CPUAlphaState *env = &cpu->env;
>
>      cs->env_ptr = env;
> -    tlb_flush(cs);
>
>      env->lock_addr = -1;
>  #if defined(CONFIG_USER_ONLY)

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

--
Alex Bennée

  parent reply	other threads:[~2018-10-09 18:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 17:45 [Qemu-devel] [PATCH v5 0/6] per-TLB lock Emilio G. Cota
2018-10-09 17:45 ` [Qemu-devel] [PATCH v5 1/6] target/alpha: remove tlb_flush from alpha_cpu_initfn Emilio G. Cota
2018-10-09 17:55   ` Peter Maydell
2018-10-09 18:20     ` Emilio G. Cota
2018-10-09 18:25       ` Peter Maydell
2018-10-09 20:48         ` Richard Henderson
2018-10-09 18:14   ` Alex Bennée [this message]
2018-10-09 20:49   ` Richard Henderson
2018-10-09 17:45 ` [Qemu-devel] [PATCH v5 2/6] target/unicore32: remove tlb_flush from uc32_init_fn Emilio G. Cota
2018-10-09 18:14   ` Alex Bennée
2018-10-09 20:49   ` Richard Henderson
2018-10-09 17:45 ` [Qemu-devel] [PATCH v5 3/6] exec: introduce tlb_init Emilio G. Cota
2018-10-09 20:49   ` Richard Henderson
2018-10-09 17:45 ` [Qemu-devel] [PATCH v5 4/6] cputlb: fix assert_cpu_is_self macro Emilio G. Cota
2018-10-09 17:45 ` [Qemu-devel] [PATCH v5 5/6] cputlb: serialize tlb updates with env->tlb_lock Emilio G. Cota
2018-10-09 17:45 ` [Qemu-devel] [PATCH v5 6/6] cputlb: read CPUTLBEntry.addr_write atomically Emilio G. Cota
2018-10-11 22:22 ` [Qemu-devel] [PATCH v5 0/6] per-TLB lock Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eirm1hp.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=cota@braap.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).