From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aQhBt-0003Hz-1I
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 15:04:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aQhBp-00012w-SD
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 15:04:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55139)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1aQhBp-00012s-MO
	for qemu-devel@nongnu.org; Tue, 02 Feb 2016 15:04:41 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1454439920-14661-1-git-send-email-eblake@redhat.com>
Date: Tue, 02 Feb 2016 21:04:38 +0100
In-Reply-To: <1454439920-14661-1-git-send-email-eblake@redhat.com> (Eric
	Blake's message of "Tue, 2 Feb 2016 12:05:20 -0700")
Message-ID: <877fimanft.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Michael Roth <mdroth@linux.vnet.ibm.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

Eric Blake <eblake@redhat.com> writes:

> Commit 86f4b687 broke compilation on sparc, which has a preprocessor
> pollution of '#define sparc 1'.  Treat it the same way as we do for
> the pollution with 'unix', so that QMP remains backwards compatible
> and only the C code needs to use the alternative 'q_sparc' spelling.
>
> CC: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> Done as a followup to the same style of patch for MIPS; or we could
> squash this into one patch.

Applied to qapi-next squashed:

    qapi: Fix compilation failure on MIPS and SPARC
    
    Commit 86f4b687 broke compilation on MIPS and SPARC, which have a
    preprocessor pollution of '#define mips 1' and '#define space 1',
    respectively.  Treat it the same way as we do for the pollution with
    'unix', so that QMP remains backwards compatible and only the C code
    needs to use the alternative 'q_mips' spelling.
    
    CC: James Hogan <james.hogan@imgtec.com>
    CC: Peter Maydell <peter.maydell@linaro.org>
    Signed-off-by: Eric Blake <eblake@redhat.com>
    Tested-by: James Hogan <james.hogan@imgtec.com>
    Signed-off-by: Markus Armbruster <armbru@redhat.com>